Skip to content

fix: pendulum in SimplePendulum simulation is rotating inverted#227

Merged
mattqdev merged 2 commits intophysicshub:mainfrom
kakarot2905:main
Mar 9, 2026
Merged

fix: pendulum in SimplePendulum simulation is rotating inverted#227
mattqdev merged 2 commits intophysicshub:mainfrom
kakarot2905:main

Conversation

@kakarot2905
Copy link
Contributor

📘 Pull Request Template – PhysicsHub

Thank you for contributing to PhysicsHub!
Please complete the sections below to help us review your pull request efficiently.


🔍 Description

Closes #ISSUE_ID (if applicable)


✅ Checklist

Before requesting a review, please ensure that you have:

  • Verified that the project builds and runs locally (npm run dev)
  • Ensured no ESLint or TypeScript warnings/errors remain
  • Updated documentation, comments, or in-code explanations where needed
  • Verified responsiveness across devices (desktop, tablet, mobile)
  • Followed the CONTRIBUTING.md guidelines

🎨 Visual Changes (if UI-related)


📂 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📝 Documentation update
  • ♻️ Refactor / code quality improvement
  • 🎨 UI/UX enhancement
  • 🔒 Security improvement

🧩 Additional Notes for Reviewers

@mattqdev
Copy link
Collaborator

mattqdev commented Mar 9, 2026

Thank you so much for this! Can you please send a short video to show how it looks?

@mattqdev mattqdev merged commit 99bce31 into physicshub:main Mar 9, 2026
1 check passed
@mattqdev
Copy link
Collaborator

mattqdev commented Mar 9, 2026

No problem, I've already check it, no need to the video.
But please always test your changes and add video referecences on your PR.
There is a bug with drag: when you click on it, it goes all the way up and it's disallinated to the drag.

Registrazione.schermo.2026-03-09.alle.21.31.14.mov

@mattqdev
Copy link
Collaborator

mattqdev commented Mar 9, 2026

Also ping the issue numer to the repo description if it close it

@physicshub
Copy link
Owner

🎉 This PR is included in version 3.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants