Fallback to default helper set when no application loader is provided#310
Open
acrobat wants to merge 1 commit intophpstan:1.2.xfrom
Open
Fallback to default helper set when no application loader is provided#310acrobat wants to merge 1 commit intophpstan:1.2.xfrom
acrobat wants to merge 1 commit intophpstan:1.2.xfrom
Conversation
acrobat
force-pushed
the
improve-gethelper-type
branch
from
cc796d4 to
52ad6de
Compare
Member
|
Please explain what effect does this have on real-world applications, thanks.
You can still create a Console Application just for the purpose of static analysis with PHPStan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using the phpstan-symfony extension in a library so I'm not able to register the standard console application loader (as you would in a regular project)
So I've added a fallback to the default helper set symfony will register during setup of the console application.
See: https://github.com/symfony/symfony/blob/ea9ed6c821f76dfc5cf0639ebd1a23db971dc6e4/src/Symfony/Component/Console/Application.php#L1096-L1107
Most of the
getHelpercases can be handled by this default set. When someone has custom helpers they should use theconsoleApplicationLoaderoption.