PhpFileCleaner: Use strcspn instead of regex for fast-skip in clean()#5600
Open
staabm wants to merge 2 commits intophpstan:2.1.xfrom
Open
PhpFileCleaner: Use strcspn instead of regex for fast-skip in clean()#5600staabm wants to merge 2 commits intophpstan:2.1.xfrom
staabm wants to merge 2 commits intophpstan:2.1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applies the upstream performance optimizations from
Jordi reported a 20-25% perf increase regarding file-cleaning with this changes (see comments in referenced PRs).
I was not able to replicate the demonstrated perf benefit of the upstream PRs in a PHPStan use-case.
(I remember though that I have seen blackfire profiles in the past, which had a bottleneck on PhpFileCleaner regex-matching)
Still I think its useful to keep our copied-in code as close to the upstream as possible.