Fix phpstan/phpstan#14325: Incorrect type inference in implode call with list<string> inside of closure

src/Analyser/NodeScopeResolver.php

@@ -2716,7 +2716,16 @@
 			$this->callNodeCallback($nodeCallback, $expr->returnType, $scope, $storage);
 		}
 
+		$phpDocParameterTypes = $this->resolveClosurePhpDocParameterTypes($stmt, $scope, $expr);
+
 		$closureScope = $scope->enterAnonymousFunction($expr, $callableParameters);
+		foreach ($phpDocParameterTypes as $paramName => $paramType) {
+			if (!$closureScope->hasVariableType($paramName)->yes()) {
+				continue;
+			}
+
+			$closureScope = $closureScope->assignVariable($paramName, $paramType, $closureScope->getNativeType(new Variable($paramName)), TrinaryLogic::createYes());
+		}
 		$closureScope = $closureScope->processClosureScope($scope, null, $byRefUses);
 		$closureType = $closureScope->getAnonymousFunctionReflection();
 		if (!$closureType instanceof ClosureType) {
@@ -4175,6 +4184,43 @@
 		}
 	}
 
+	/**
+	 * @return array<string, Type>
+	 */
+	private function resolveClosurePhpDocParameterTypes(Node\Stmt $stmt, MutatingScope $scope, Expr\Closure $closure): array
+	{
+		$phpDocParameterTypes = [];
+
+		foreach ($stmt->getComments() as $comment) {
+			if (!$comment instanceof Doc) {
+				continue;
+			}
+
+			$resolvedPhpDoc = $this->fileTypeMapper->getResolvedPhpDoc(
+				$scope->getFile(),
+				$scope->isInClass() ? $scope->getClassReflection()->getName() : null,
+				$scope->isInTrait() ? $scope->getTraitReflection()->getName() : null,
+				$scope->getFunction() !== null ? $scope->getFunction()->getName() : null,
+				$comment->getText(),
+			);
+
+			foreach ($resolvedPhpDoc->getParamTags() as $paramName => $paramTag) {
+				foreach ($closure->params as $param) {
+					if (
+						$param->var instanceof Variable
+						&& is_string($param->var->name)
+						&& $param->var->name === $paramName
+					) {
+						$phpDocParameterTypes[$paramName] = $paramTag->getType();
+						break;
+					}
+				}
+			}
+		}
+
+		return $phpDocParameterTypes;
+	}
+
 	/**
 	 * @return array{TemplateTypeMap, array<string, Type>, array<string, bool>, array<string, Type>, ?Type, ?Type, ?string, bool, bool, bool, bool|null, bool, bool, string|null, Assertions, ?Type, array<string, Type>, array<(string|int), VarTag>, bool, ?ResolvedPhpDocBlock}
 	 */

tests/PHPStan/Analyser/nsrt/bug-14325.php

@@ -0,0 +1,45 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14325;
+
+use function PHPStan\Testing\assertType;
+
+/**
+ * @param list<string> $array
+ */
+function func(array $array): void
+{
+	assertType('list<string>', $array);
+	$array[] = 'bar';
+	assertType('non-empty-list<string>', $array);
+}
+
+/**
+ * @param list<string> $array
+ */
+$func = function(array $array): void
+{
+	assertType('list<string>', $array);
+	$array[] = 'bar';
+	assertType('non-empty-list<string>', $array);
+};
+
+class Foo
+{
+	/**
+	 * @param list<string> $array
+	 */
+	public function method(array $array): void
+	{
+		assertType('list<string>', $array);
+
+		/**
+		 * @param list<string> $inner
+		 */
+		$closure = function (array $inner): void {
+			assertType('list<string>', $inner);
+			$inner[] = 'baz';
+			assertType('non-empty-list<string>', $inner);
+		};
+	}
+}

tests/PHPStan/Analyser/nsrt/count-type.php

@@ -104,11 +104,11 @@ public function constantArrayWhichCanBecomeList(string $h): void
  */
 function(\ArrayObject $obj): void {
 	if (count($obj) === 0) {
-		assertType('ArrayObject', $obj);
+		assertType('ArrayObject<int, mixed>', $obj);
 		return;
 	}
 
-	assertType('ArrayObject', $obj);
+	assertType('ArrayObject<int, mixed>', $obj);
 };
 
 function($mixed): void {