Fix #7719: ReflectionMethod with invokeArgs: Dead catch - exception is never thrown in the try block.

[phpstan-bot]

Summary

PHPStan incorrectly reported "Dead catch - RuntimeException is never thrown in the try block" when catching exceptions around ReflectionMethod::invoke() and ReflectionMethod::invokeArgs() calls. These methods execute arbitrary user code via reflection and can throw any exception, not just ReflectionException.

Changes

• Added src/Type/Php/ReflectionMethodInvokeMethodThrowTypeExtension.php — a DynamicMethodThrowTypeExtension that declares ReflectionMethod::invoke(), ReflectionMethod::invokeArgs(), ReflectionFunction::invoke(), and ReflectionFunction::invokeArgs() can throw Throwable
• Added regression test tests/PHPStan/Rules/Exceptions/data/bug-7719.php covering all four methods
• Added test method testBug7719() to CatchWithUnthrownExceptionRuleTest.php
• Updated phpstan-baseline.neon with one new entry for the extension file

Root cause

The BetterReflection library's adapter class (vendor/ondrejmirtes/better-reflection/src/Reflection/Adapter/ReflectionMethod.php) has @throws ReflectionException annotations on invoke() and invokeArgs(). PHPStan reads these throw type annotations and concludes that only ReflectionException can be thrown by these methods. However, in real PHP, ReflectionMethod::invoke() and invokeArgs() execute arbitrary user code that can throw any exception. The fix adds a dynamic throw type extension that overrides this to return Throwable, correctly indicating that any exception type is possible.

Test

The regression test in tests/PHPStan/Rules/Exceptions/data/bug-7719.php creates four scenarios:

1. ReflectionMethod::invokeArgs() with a dynamic method name — catch RuntimeException should not be reported as dead
2. ReflectionMethod::invoke() with a dynamic method name — same
3. ReflectionFunction::invokeArgs() with a dynamic function name — same
4. ReflectionFunction::invoke() with a dynamic function name — same

All four expect no errors (empty expected errors array).

Fixes phpstan/phpstan#7719

Closes phpstan/phpstan#9267

[staabm]

@phpstan-bot instead of implementing a DynamicMethodThrowTypeExtension, declare a @throws type in ReflectionMethod stubs

[phpstan-bot]

Claude finished @staabm's task in 4m 36s —— View job

---

Implemented stub-based approach for @throws types

• Understand current implementation
• Find ReflectionMethod/ReflectionFunction stubs
• Add @throws \Throwable to ReflectionMethod.stub for invoke() and invokeArgs()
• Create ReflectionFunction.stub with @throws \Throwable for invoke() and invokeArgs()
• Register ReflectionFunction.stub in conf/config.neon
• Remove DynamicMethodThrowTypeExtension class
• Remove baseline entry for the extension file
• Commit and push changes

Summary

Replaced the DynamicMethodThrowTypeExtension approach with @throws \Throwable annotations in stubs, as suggested:

• stubs/ReflectionMethod.stub — added invoke() and invokeArgs() with @throws \Throwable
• stubs/ReflectionFunction.stub — new file with invoke() and invokeArgs() with @throws \Throwable
• conf/config.neon — registered the new ReflectionFunction.stub
• Deleted src/Type/Php/ReflectionMethodInvokeMethodThrowTypeExtension.php and its baseline entry
• Existing regression tests (bug-7719.php, bug-9267.php) are unchanged and should continue to pass

Note: I was unable to run tests locally due to sandbox restrictions. CI will validate the changes.

[staabm]

@phpstan-bot discard the change to tmp/cache/.gitignore

[phpstan-bot]

Claude finished @staabm's task in 29s —— View job

---

Discarding change to tmp/cache/.gitignore

• Restore tmp/cache/.gitignore from base branch
• Commit and push

Restored tmp/cache/.gitignore to its original state.

[staabm]

I verified the tests failling without the fix locally.

[VincentLanglet]

I feel like this will create lot of false positive on the overside for someone using missingCheckedExceptionInThrows (I personally do it a lot, don't you @staabm ?).

It will require (useless) try/catch or adding @throws every where every time invoke is used, even if we know the method/function won't throw any exception.

It would be better if the throwPoint could be Implicit rather than Explicit in order to avoid both the DeadCatch and reporting missingType.checkedException

Best would be to have a dynamicReturnTypeExtension/dynamicThrowTypeExtension, but this would require changing those class to be generic I think