Fix BcMath\Number increment/decrement

[mpesari]

Partial fix for phpstan/phpstan#13965

This adds support for BcMath\Number increment/decrement operations on PHP >= 8.4.

php > $x = new BcMath\Number('3.14');
php > print $x;
3.14
php > $x++;
php > print $x;
4.14

[phpstan-bot]

You've opened the pull request against the latest branch 2.2.x. PHPStan 2.2 is not going to be released for months. If your code is relevant on 2.1.x and you want it to be released sooner, please rebase your pull request and change its target to 2.1.x.

[VincentLanglet]

You need to target 2.1.x

[mpesari]

Rebased and targeted to 2.1.x

[mpesari]

Hmm.. I wanted to make sure that we report errors on PHP < 8.4 when the polyfill is installed, but looks like the test doesn't report any errors.

[VincentLanglet]

Please take a new look @staabm with the changes

[staabm]

I like the PR so far.

per https://www.php.net/manual/en/class.bcmath-number.php

A class for an arbitrary precision number. These objects support overloaded arithmetic and comparison operators.

this class also has special comparison semantics. I think it would make sense to cover both aspects in this PR.
@mpesari could you look into comparisons?

[VincentLanglet]

I like the PR so far.

per php.net/manual/en/class.bcmath-number.php

A class for an arbitrary precision number. These objects support overloaded arithmetic and comparison operators.

this class also has special comparison semantics. I think it would make sense to cover both aspects in this PR. @mpesari could you look into comparisons?

Isn't already handled by

phpstan-src/src/Type/Php/BcMathNumberOperatorTypeSpecifyingExtension.php

Line 17 in c2da2e8

final class BcMathNumberOperatorTypeSpecifyingExtension implements OperatorTypeSpecifyingExtension

?

[staabm]

you are right. its covered in tests/PHPStan/Analyser/nsrt/bcmath-number.php

[staabm]

thank you @mpesari