Open
Conversation
VincentLanglet
requested review from
ondrejmirtes and
staabm
and removed request for
staabm
Collaborator
|
This pull request has been marked as ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I dunno if this is the famous "hard-to-reproduce bug" you tried to fix @ondrejmirtes
since you touched related code f65449b
as markus reported the initial commit introducing the issue as #4719
(cf phpstan/phpstan#13984 (comment))
I looked at every expr class and seems like not filtering FuncCall is solving the issue.
Seems like it
Fixes phpstan/phpstan#13984