Fix invokable objects incorrectly labeled as instances of Closure
#4797
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
force-pushed
the
fix-13975
branch
8 times, most recently
from
a02e586 to
6d1e13c
Compare
HypeMC
commented
Feb 3, 2026
src/Type/Accessory/HasMethodType.php
Outdated
| if ( | ||
| $this->isCallable()->yes() | ||
| && $otherType->isCallable()->yes() | ||
| && !($otherType->isObject()->yes() && $otherType->isInstanceOf(Closure::class)->yes()) |
Author
There was a problem hiding this comment.
@ondrejmirtes Hi, I'm not sure how to proceed here. I tried using instanceof, but PHPStan said I should use isObject() instead. Now I'm getting this error. Any advice?
Contributor
There was a problem hiding this comment.
see other similar spots in the codebase.
it need to look like (new ObjectType(Closure::class))->isSuperTypeOf(...)
staabm
reviewed
Feb 3, 2026
| $this->assertNoErrors($errors); | ||
| } | ||
|
|
||
| public function testBug13975(): void |
Contributor
There was a problem hiding this comment.
your test needs to be moved into a *RuleTest which relates to the error message you no longer want to have.
AnalyzerIntegrationTest is reserved for performance and crash-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13975