Skip to content

ext/gmp: Emit deprecation for precision-losing float RHS in ** / << / >> #21935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LamentXU123 wants to merge 6 commits into
base: PHP-8.4
Choose a base branch
from
+17 −3
Open

ext/gmp: Emit deprecation for precision-losing float RHS in ** / << / >> #21935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1de8497
init
LamentXU123 May 2, 2026
f2fc4fc
init
LamentXU123 May 2, 2026
e8f1040
Merge branch 'bug-fix-9' of https://github.com/LamentXU123/php-src in…
LamentXU123 May 2, 2026
3194cc4
fix blankets
LamentXU123 May 2, 2026
52a14b3
fix UPGRADING
LamentXU123 May 3, 2026
9ae23e6
Fix CI to adopt in C23...
LamentXU123 May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ PHP NEWS
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
?? ??? ????, PHP 8.4.22

- GMP:
. GMP exponentiation and shift operators now emit a deprecation warning
when converting a float right operand to int loses precision. (Weilin Du)

- Opcache:
. Fixed tracing JIT crash when a VM interrupt is handled during an observed
user function call. (Levi Morrison)
Expand Down
4 changes: 4 additions & 0 deletions UPGRADING
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ PHP 8.4 UPGRADE NOTES
. Gettext:
. bind_textdomain_codeset, textdomain and d(*)gettext functions now throw an exception
if the domain argument is empty.
. GMP:
. The shift (<<, >>) and exponentiation (**) operators on GMP objects now
emit a deprecation warning when converting a float right operand to int
loses precision.
. Intl:
. resourcebundle_get(), ResourceBundle::get(), and accessing offsets on a
ResourceBundle object now throw:
Expand Down
6 changes: 3 additions & 3 deletions ext/gmp/gmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,11 +347,11 @@ static zend_result shift_operator_helper(gmp_binary_ui_op_t op, zval *return_val

if (UNEXPECTED(Z_TYPE_P(op2) != IS_LONG)) {
if (UNEXPECTED(!IS_GMP(op2))) {
// For PHP 8.3 and up use zend_try_get_long()
bool failed;
switch (Z_TYPE_P(op2)) {
case IS_DOUBLE:
shift = zval_get_long(op2);
if (UNEXPECTED(EG(exception))) {
shift = zval_try_get_long(op2, &failed);
if (UNEXPECTED(failed)) {
return FAILURE;
}
break;
Expand Down
6 changes: 6 additions & 0 deletions ext/gmp/tests/overloading_with_float_fractional.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ object(GMP)#2 (1) {
["num"]=>
string(1) "0"
}

Deprecated: Implicit conversion from float 42.5 to int loses precision in %s on line %d
object(GMP)#2 (1) {
["num"]=>
string(69) "150130937545296572356771972164254457814047970568738777235893533016064"
Expand All @@ -122,10 +124,14 @@ object(GMP)#2 (1) {
["num"]=>
string(1) "0"
}

Deprecated: Implicit conversion from float 42.5 to int loses precision in %s on line %d
object(GMP)#2 (1) {
["num"]=>
string(15) "184717953466368"
}

Deprecated: Implicit conversion from float 42.5 to int loses precision in %s on line %d
object(GMP)#2 (1) {
["num"]=>
string(1) "0"
Expand Down
Loading