Mysqli mem fixes#21930
Open
devnexen wants to merge 2 commits intophp:PHP-8.4from
Open
Conversation
… errors. When MYSQLI_REPORT_INDEX is enabled, mysqli_execute_query() duplicates the query string into stmt->query. The two input_params validation error branches freed the MY_STMT wrapper directly without releasing stmt->query, leaking the duplicated string per failing call.
Member
|
This was copied from |
Member
Author
|
Checked it, I think prepare is actually fine. The estrdup there is guarded by stmt->stmt being non-NULL, and the efree(stmt) early-return only runs when stmt->stmt is The reason execute_query leaks is the order, the estrdup runs before the input_params checks, and those checks bail with efree(stmt) without touching the dup. Same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.