[RFC] ReflectionAttribute::getCurrent()#21440
Open
DanielEScherzer wants to merge 2 commits intophp:masterfrom
Open
[RFC] ReflectionAttribute::getCurrent()#21440DanielEScherzer wants to merge 2 commits intophp:masterfrom
DanielEScherzer wants to merge 2 commits intophp:masterfrom
Conversation
Crell
reviewed
Mar 16, 2026
| #[Attribute] | ||
| class Demo { | ||
| public function __construct( $args ) { | ||
| echo ReflectionAttribute::getCurrent(); |
Contributor
There was a problem hiding this comment.
I think it's more common to use var_dump here.
Contributor
There was a problem hiding this comment.
Though, I'd also be fine with just echoing the name property/method of the object rather than dumping the whole object. Other internals regulars may have a different opinion...
Contributor
|
I believe we'd also want tests to confirm what happens if that method is called outside the constructor, and how it will error (or null, or whatever it's going to do). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.