Open
Conversation
ramsey
requested review from
DanielEScherzer,
Girgias,
NattyNarwhal,
SakiTakamachi,
TimWolla,
adoy,
alexdowad,
arnaud-lb,
bukka,
derickr,
devnexen,
dstogov,
kamil-tekiela,
kocsismate,
ndossche,
youkidearitai and
zeriyoshi
as code owners
| #else | ||
| # define ZEND_OPCODE_HANDLER_ARGS zend_execute_data *execute_data, const zend_op *opline | ||
| # define ZEND_OPCODE_HANDLER_ARGS_PASSTHRU execute_data, opline | ||
| # define ZEND_OPCODE_HANDLER_ARGS_EX ZEND_OPCODE_HANDLER_ARGS, |
Member
There was a problem hiding this comment.
presumably your IDE removed the spaces - the removals are causing CI to fail
Member
Author
There was a problem hiding this comment.
Huh. Looks like it. I've had this change in there since June 28 last year. 🤦♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR encompasses the changes proposed in the PHP License Update RFC for the PHP source code.
Discussion is available on the internals mailing list.
Changes proposed for the PHP website are available at php/web-php#1762.