Clean up dead declarations, const lookup table, and indentation#63
Open
iliaal wants to merge 1 commit into
Open
Clean up dead declarations, const lookup table, and indentation#63iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
No behaviour change. - php_mailparse.h: drop prototypes for five functions that are neither defined nor registered (mailparse_msg_find, _getstructure, _getinfo, _extract, _extract_file) and the duplicate mailparse_msg_parse_file prototype. - mailparse_encoding.c: mark the read-only hex2code_map lookup table const, and drop a stale "output a marker" comment in the base64 decoder (the code just ignores the byte). - Re-tab two space-indented blocks (add_attr_header_to_zval and the duplicate-header branch in php_mimepart_process_header) to match the surrounding tab indentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosmetic cleanup, no behaviour change.
php_mailparse.h: remove prototypes for five functions that are neither defined nor registered (mailparse_msg_find,mailparse_msg_getstructure,mailparse_msg_getinfo,mailparse_msg_extract,mailparse_msg_extract_file), plus the duplicatemailparse_msg_parse_fileprototype.mailparse_encoding.c: mark the read-onlyhex2code_maplookup tableconst(it sits next to the already-constmb_base64_table), and drop the misleading "output a marker but continue" comment in the base64 decoder — the code just ignores the byte.add_attr_header_to_zvaland the duplicate-header branch inphp_mimepart_process_header) to match the surrounding tab indentation.