Use memchr for end-of-line scan in php_mimepart_parse#57
Open
iliaal wants to merge 1 commit into
Open
Conversation
The per-chunk newline search was a hand-rolled byte-at-a-time loop. memchr lets libc scan a word at a time, which matters because this is the inner loop of all message parsing. Behaviour is unchanged: a chunk with a newline is appended up to and including the '\n' and handed to php_mimepart_process_line; a chunk without one is buffered for the next call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_mimepart_parsescans each input chunk for the next newline to split it into lines, which is the inner loop of all message parsing. Replaced the hand-rolled byte-at-a-time scan withmemchrso libc can scan a machine word at a time. Behaviour is unchanged: a chunk with a newline is appended through the\nand handed tophp_mimepart_process_line; a chunk without one is buffered for the next call.