Conversation
Contributor
Author
|
fyi @xavierleune, I can also close this PR if you prefer to look into it yourself. |
AlliBalliBaba
requested review from
dunglas,
henderkes and
withinboredom
and removed request for
withinboredom
henderkes
approved these changes
Feb 16, 2026
Contributor
|
thanks @AlliBalliBaba I'm looking into it |
dunglas
force-pushed
the
fix/session-handlers
branch
from
e8ac30a to
52a5735
Compare
dunglas
force-pushed
the
fix/session-handlers
branch
from
52a5735 to
c5d4285
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts session logic from #2139 and fixes #2190, #2187, #2185.
As you can see in
TestSessionHandler_worker, session handlers work fine, but you have to re-register them on every request, which is just easier to do in PHP code.What this PR keeps: removing
$_SESSIONfrom the symbol table.