Remove 72 unused entities from language-snippets.ent#5625
Open
lacatoire wants to merge 1 commit into
Open
Conversation
lacatoire
force-pushed
the
cleanup/unused-language-snippets-entities
branch
from
9cf3e64 to
1b5d586
Compare
Member
|
Also checked non usage on translations? But even if some outdated translations still use some of then, keep the deletion. Anything that shrinks And after php/doc-base#301 is merged, any deleted entity on doc-en still used for translations can now be moved to a temporary file, so full remotions on |
lacatoire
force-pushed
the
cleanup/unused-language-snippets-entities
branch
from
1b5d586 to
11e7920
Compare
lacatoire
changed the title
lacatoire
force-pushed
the
cleanup/unused-language-snippets-entities
branch
from
11e7920 to
4395196
Compare
Member
Author
Member
|
That is impressive. You have a comprehensive view of dependencies between these DTD entities and languages. Hope that doc-base's 301 will help make this work easier. In fact, #5628 may be the first use/user of an |
sy-records
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auditing
language-snippets.entsurfaced unused entity declarations that are not referenced anywhere, directly or transitively: deprecation banners for old PHP cycles, snippets for removed extensions (mcrypt, sqlite, t1lib, safemode, ...) and stale helpers.This removes the 72 that no translation references either. The 11 entities still referenced by some translations are split into a separate PR.
Pure cleanup, no rendered output changes.