Fix fd leak and stale socket issues (security audit)#11
Merged
Conversation
1. Close socket on remote_init failure (com.c) When early connect succeeds but DBGp handshake fails, the socket was never closed — causing fd exhaustion under repeated failures. 2. Reset socket fd to -1 after close (com.c) xdebug_mark_debug_connection_not_active() closed the socket but left the old fd value, risking use-after-close if the fd is reused. 3. Add PHP_DEBUGGER_SESSION_START to RINIT pre-check (xdebug.c) The early connect pre-check only tested XDEBUG_SESSION_START env var but not the new alias, causing early connect to be skipped when using the new trigger name.
pronskiy
force-pushed
the
security-fixes
branch
from
1922b71 to
03c6c42
Compare
carlos-granados
approved these changes
Mar 23, 2026
Collaborator
carlos-granados
left a comment
carlos-granados
left a comment
There was a problem hiding this comment.
Looks good, thanks @pronskiy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased from closed PR #9.
Fixes file descriptor leaks and stale socket issues identified during security audit.