fix: schema-sharded fallback routing (#819)#953
Open
Munawwar wants to merge 4 commits intopgdogdev:mainfrom
Open
fix: schema-sharded fallback routing (#819)#953Munawwar wants to merge 4 commits intopgdogdev:mainfrom
Munawwar wants to merge 4 commits intopgdogdev:mainfrom
Conversation
|
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
dc841c1 to
b9393e0
Compare
This reverts commit 1b915e7.
Author
|
@levkk changes are ready for review. Check my previous comment as well please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR logic explained at #819 (comment)
TODO: Haven't added Client/query-engine test yet.There are two edge cases I haven't handled:
@levkk I added more tests to increase coverage and then reverted it. It's just significantly more LoC