Skip to content

fix: schema-sharded fallback routing (#819)#953

Open
Munawwar wants to merge 4 commits intopgdogdev:mainfrom
Munawwar:819-cross-shard-fix
Open

fix: schema-sharded fallback routing (#819)#953
Munawwar wants to merge 4 commits intopgdogdev:mainfrom
Munawwar:819-cross-shard-fix

Conversation

@Munawwar
Copy link
Copy Markdown

@Munawwar Munawwar commented May 1, 2026

PR logic explained at #819 (comment)

TODO: Haven't added Client/query-engine test yet.

There are two edge cases I haven't handled:

  1. this could work incorrectly if the schema is still loading in the background and its not completed yet
  2. load_schema = Off (well .. what to do here even?)

@levkk I added more tests to increase coverage and then reverted it. It's just significantly more LoC

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

@Munawwar Munawwar force-pushed the 819-cross-shard-fix branch 2 times, most recently from dc841c1 to b9393e0 Compare May 2, 2026 15:09
@Munawwar
Copy link
Copy Markdown
Author

Munawwar commented May 4, 2026

@levkk changes are ready for review. Check my previous comment as well please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants