Add smartsnap endpoints to percy client#2207
Open
RaghavsBrowserStack wants to merge 11 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!/^[\w.-]+\.json$/i.test(statsName)) { | ||
| throw new SmartSnapBailError(`SmartSnap: invalid statsFile "${statsName}" — must be a .json filename; running full snapshot set`); | ||
| } | ||
| const resolvedStatsPath = path.join(path.resolve(buildDir), statsName); |
| if (!/^[\w.-]+\.json$/i.test(statsName)) { | ||
| throw new SmartSnapBailError(`SmartSnap: invalid statsFile "${statsName}" — must be a .json filename; running full snapshot set`); | ||
| } | ||
| const resolvedStatsPath = path.join(path.resolve(buildDir), statsName); |
| throw new SmartSnapBailError(`SmartSnap: manifest changes span multiple directories (${uniqueDirs.join(', ')}); running full snapshot set`); | ||
| } | ||
| const manifestDir = uniqueDirs[0]; // repo-relative; '.' for root | ||
| const absManifestDir = path.resolve(projectRoot, manifestDir); |
| // coexist (e.g. a stray package-lock.json next to yarn.lock) we can't | ||
| // pick a canonical source, so bail. | ||
| const LOCKFILE_NAMES = ['package-lock.json', 'yarn.lock', 'pnpm-lock.yaml']; | ||
| const presentLockfiles = LOCKFILE_NAMES.filter(n => fs.existsSync(path.join(absManifestDir, n))); |
| // coexist (e.g. a stray package-lock.json next to yarn.lock) we can't | ||
| // pick a canonical source, so bail. | ||
| const LOCKFILE_NAMES = ['package-lock.json', 'yarn.lock', 'pnpm-lock.yaml']; | ||
| const presentLockfiles = LOCKFILE_NAMES.filter(n => fs.existsSync(path.join(absManifestDir, n))); |
| throw new SmartSnapBailError(`SmartSnap: lockfile "${lockfileRepoPath}" not present at base ref ${baseRef}; running full snapshot set`); | ||
| } | ||
|
|
||
| const newLockfile = fs.readFileSync(path.join(absManifestDir, lockfileName), 'utf8'); |
| if (oldLockfile !== newLockfile) { | ||
| // Lockfile actually shifted — invoke the diff. If byte-identical, only | ||
| // package.json's non-dep fields changed and we fall through unchanged. | ||
| const packageJson = fs.readFileSync(path.join(absManifestDir, 'package.json'), 'utf8'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.