docs: proper GitHub Dark theme for code blocks#507
Open
zubricks wants to merge 1 commit into
Open
Conversation
… through Prism's TSX tokenizer, which produced incorrect highlighting for any non-TS language. This change honors the stored `language` field end-to-end and rebuilds the theme against the @primer/primitives dark palette used by GitHub and the official VS Code GitHub Dark theme. - thread the fence language through RichText → Code → prism-react-renderer - replace the hand-tuned palette with true GitHub Dark hex values - register Prism components: bash, scss, dockerfile, http, css-extras - delete the parallel :global CSS theme in index.module.scss that was competing with the JS theme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Code component ignored the MDX fence language and ran every block through Prism's TSX tokenizer, which produced incorrect highlighting for any non-TS language. This change honors the stored
languagefield end-to-end and rebuilds the theme against the @primer/primitives dark palette used by GitHub and the official VS Code GitHub Dark theme.Examples
Current CSS Block
Updated CSS Block
Current plaintext Block
Updated plaintext Block
Current bash Block
Updated bash Block
Current YML Block
Updated YML Block