fix: Updated drag and drop to use the correct glass theme.#12306
fix: Updated drag and drop to use the correct glass theme.#12306dlabaj wants to merge 1 commit intopatternfly:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughTwo independent updates: a CSS custom property change for drag-drop overlay styling, and an icon asset mapping update for the grip vertical icon variant. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12306.surge.sh A11y report: https://pf-react-pr-12306-a11y.surge.sh |
| FolderOpenIcon: { name: 'rh-ui-folder-open', icon: getIconData('rh-ui-folder-open') }, | ||
| GripHorizontalIcon: { name: 'rh-ui-grip-horizontal', icon: getIconData('rh-ui-grip-horizontal') }, | ||
| GripVerticalIcon: { name: 'rh-ui-grip-vertical', icon: getIconData('rh-ui-grip-vertical') }, | ||
| GripVerticalIcon: { name: 'rh-ui-grip-vertical-fill', icon: getIconData('rh-ui-grip-vertical-fill') }, |
There was a problem hiding this comment.
Can we update the drag icon used in DragButton to the new RhUiGripVerticalFillIcon directly? We can still keep this update for product team migration.
There was a problem hiding this comment.
It also looks like the PR needs a snapshot update.
Fixes #12269 by updating the styling for drag and drop.
Summary by CodeRabbit