docs(AI): Updates AI resources with latest guidance.#4967
docs(AI): Updates AI resources with latest guidance.#4967edonehoo wants to merge 4 commits intopatternfly:mainfrom
Conversation
phcox
left a comment
There was a problem hiding this comment.
Hey Erin,
I concentrated mostly on the new Design Language page, but I did read everything else and it all looked good to me.
Comments on the Design Language page:
- The images aren't being displayed very well. The resolution is off and they look grainy. The icons are somewhat better but even they seem a little off.
- It seems like the two robot icon variants should be presented when they are being described, maybe even in context to better differentiate them.
- Typo in this sentence: "Do not communicate the use of AI through icons alone. Ensure they are also paited with a text label or tooltip."
- This sentence may not be entirely accurate: "Because avatars have personality and don't have interactive state changes, you can adjust the background colors of the standard robot icon, including adding soft gradients or drop shadows to create depth." I think the colors will be limited to either PF non-status or RH brand color for non-interactivity, but that conversation just got brought up again in our design language meeting. Kayla is going to talk to Andrew on 3/25 to try to come to a resolution. Regardless, we don't want to say that soft gradients and drop shadows are OK - we backed off that as we iterated on the deck.
- This sentence: "There are different icon variations and animations available to show thinking states, react to content, or differentiate chatbot options." This isn't true at the moment. It's something we'll look at in the future. I suggest removing it.
- This sentence: "AI is represented by a sparkle icon, which is square with slightly rounded corners." This is probably just a personal preference, but I don't think of that sparkle as being square; to me it's more like a diamond with concave sides.
That's all I've got. Looks really good!
|
@phcox ty for the review! I made those typo/copy changes Do the images still look grainy to you? They look okay on my end, but there might be a browser/monitor difference that I could look into. Definitely agree re the robot icons, but they're not in Figma yet (unless I just can't find them), so this PR will need to wait for those to be uploaded. Similarly, I'll add in an image of the color options for the avatar version once those are finalized and available |
|
Looking at the images again, everything is fine except for the Figma screen captures. They seem pretty washed out and low-res. All the text changes LGTM. If you want to get this wrapped up, I bet we could find the robot images outside of Figma for you to use. |
Closes #4621 and #4792
Will require a follow-up in chatbot repo to add back some info I'm removing from these docs (handling unsafe user requests, message streaming)