feat(background-image): port pf-v5-background-image to pf-v6-background-image#3151
Draft
zeroedin wants to merge 1 commit into
Draft
feat(background-image): port pf-v5-background-image to pf-v6-background-image#3151zeroedin wants to merge 1 commit into
pf-v5-background-image to pf-v6-background-image#3151zeroedin wants to merge 1 commit into
Conversation
|
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pf-v5-background-image to pf-v6-background-image
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "feat(background-image): port `pf-v5-background-image` to `pf-v6-background-image`"
} |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<pf-v5-background-image><pf-v5-background-image>to<pf-v6-background-image>web component for PatternFly v6srcattribute (matching React v6)--pf-v6-c-background-image--*design tokens matching PatternFly v6 SCSSclamp()with configurable min/width/max tokens:host(:dir(rtl))(replaces SCSS bidirectional mixin)aria-hidden="true"on background container for WCAG complianceCloses #2980
Intentional divergences from React
--pf-v6-c-background-image--BackgroundPositionexposed as a public CSS custom property (React sets this internally via SCSSbidirectional mixin; shadow DOM prevents class-level overrides)
Test plan
npm run testpasseslocalhost:8000with?rendering=chromelesssrcattribute sets the background image URLsrcclears the background image--min-width,--width,--max-width) are respectedaria-hidden)Assisted-By: Claude
Testing Instructions
Notes to Reviewers