fix: skip casting columns typed as typing.Any in rest_connector#228
Open
SAY-5 wants to merge 1 commit intopathwaycom:mainfrom
Open
fix: skip casting columns typed as typing.Any in rest_connector#228SAY-5 wants to merge 1 commit intopathwaycom:mainfrom
SAY-5 wants to merge 1 commit intopathwaycom:mainfrom
Conversation
Calling typing.Any(value) raises TypeError, so requests against the default rest_connector schema (which infers query as Any) failed on every payload. Skip the cast when the column type is Any. Fixes pathwaycom#227 Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
To contribute code to the Pathway project, start by discussing your proposed changes on Discord or by filing an issue.
Once approved, follow the fork + pull request model against the main branch, ensuring you've signed the contributor license agreement.
Context
pw.io.http.rest_connectorbuilds a default schema withquery: Anywhen no schema is supplied (_server.pyL832). On every request,_cast_types_to_schemathen runspayload[column] = exact_type(payload[column]), which becomestyping.Any(value)and raisesTypeError: Cannot instantiate typing.Any(CPythontyping.py_SpecialForm.__call__).The cast is inside a
try/except Exceptionthat logs but silently drops the value, so every default-schema request loses its payload and emits a noisy traceback. Fix: skip the cast when the column's exact type isAny, since "any" means "no conversion".How has this been tested?
Reproduced the failure path in isolation against the existing logic and confirmed the patched version no longer raises and leaves
Any-typed values untouched while still casting other columns (e.g.int).Types of changes
Related issue(s):
Checklist: