Extract _guess_type from convert_type and add overloads#3372
Draft
kdeldycke wants to merge 1 commit intopallets:stablefrom
Draft
Extract _guess_type from convert_type and add overloads#3372kdeldycke wants to merge 1 commit intopallets:stablefrom
_guess_type from convert_type and add overloads#3372kdeldycke wants to merge 1 commit intopallets:stablefrom
Conversation
This is a refactor that was original part of `typing/paramtype` branch but split out of pallets#3371 to keep the latter focused on typing only. Co-authored-by: Kevin Deldycke <kevin@deldycke.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor that was original part of
typing/paramtypebranch by @AndreasBackx, then split out of #3371 to keep the latter focused on typing only.It is kept in its separate PR to untied it from pure typing improvements from #3371 and further study and evaluation.