Split string values from default_map for multi-value parameters#3364
Open
kdeldycke wants to merge 1 commit intopallets:stablefrom
Open
Split string values from default_map for multi-value parameters#3364kdeldycke wants to merge 1 commit intopallets:stablefrom
default_map for multi-value parameters#3364kdeldycke wants to merge 1 commit intopallets:stablefrom
Conversation
kdeldycke
force-pushed
the
fix-default-map-nargs
branch
from
e2784dc to
cc5417f
Compare
kdeldycke
force-pushed
the
fix-default-map-nargs
branch
from
cc5417f to
63ee5ec
Compare
Collaborator
|
Approved! Will merge once 8.3.3 goes out. |
kdeldycke
force-pushed
the
fix-default-map-nargs
branch
from
63ee5ec to
56370d0
Compare
Collaborator
Author
Take your time, there is no rush! I am aligning all the obvious bug fixes to purge the backlog for the next dev cycle. In the mean time, just added a "Multi-value parameters" section to the docs as you suggested in #2745 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue reported in #2745 is still present on
stablebranch, in which data fromdefault_mapis naively processed whennargs > 1bytype_cast_valueand unpack each characters from a string.The fix consist in evaluating these data as if they are environment variables, where we are in a strict string-domain.