Skip to content

[FEATURE REQUEST] Make the spaces icon color brandable#4877

Merged
joragua merged 2 commits into
masterfrom
feature/space_icon_color_brandable
Jun 1, 2026
Merged

[FEATURE REQUEST] Make the spaces icon color brandable#4877
joragua merged 2 commits into
masterfrom
feature/space_icon_color_brandable

Conversation

@joragua
Copy link
Copy Markdown
Contributor

@joragua joragua commented Jun 1, 2026

Related Issues

App: #4860

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

#4877 (comment)

@joragua joragua self-assigned this Jun 1, 2026
@joragua joragua linked an issue Jun 1, 2026 that may be closed by this pull request
9 tasks
@joragua joragua force-pushed the feature/space_icon_color_brandable branch from 387ec66 to 4ba6c78 Compare June 1, 2026 08:53
@joragua joragua marked this pull request as ready for review June 1, 2026 09:15
@joragua joragua requested a review from jesmrec June 1, 2026 09:15
@joragua joragua force-pushed the feature/space_icon_color_brandable branch from 4ba6c78 to 30b0c14 Compare June 1, 2026 09:26
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR approved, moving to QA

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Jun 1, 2026

QA checks:

  • Vanilla app

    • Spaces list (no space image)
    • Spaces bottom card
    • Members/links view
    • Details view
    • Uploads view and av. offline list in legacy color
  • Branded app x4

    • Spaces list (no space image)
    • Spaces bottom card
    • Members/links view
    • Details view
    • Uploads view and av. offline list in legacy color

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Jun 1, 2026

This is approved on my side

@joragua joragua merged commit df49420 into master Jun 1, 2026
10 checks passed
@joragua joragua deleted the feature/space_icon_color_brandable branch June 1, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Make the spaces icon color brandable

2 participants