AO3-7522 Update browser page title when editing news post#5909
AO3-7522 Update browser page title when editing news post#5909LepusCavum wants to merge 2 commits into
Conversation
sarken
left a comment
sarken
left a comment
There was a problem hiding this comment.
Hi, Megan Joy (lepuscavum418)!
Thank you so much for this pull request. It looks pretty good -- just a small note about the key name.
I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."
Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.
Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.
| def edit | ||
| @admin_post = AdminPost.find(params[:id]) | ||
| authorize @admin_post | ||
| @page_subtitle = t(".page_title_edit") |
There was a problem hiding this comment.
Could you change this to just .page_title? That's our standard key name for browser page titles. We only add more words if there are variations, e.g., different text for published news or draft news.
There was a problem hiding this comment.
No problem, I've pushed the update, just waiting on the automated checks to finish running. Thanks for the quick review!
github-actions
Bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Account Name: Megan Joy |
sarken
left a comment
sarken
left a comment
There was a problem hiding this comment.
Looks good to me!
Your Jira permissions should be all set next time you log in, but if you run into any issues, please let me know.
2 participants
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7522
Purpose
What does this PR do?
This PR changes the browser tab title on the Admin News Editing page to say "Edit AO3 News Post" like the header.
Credit
Name: Megan Joy (lepuscavum418)
Pronouns: she/her