Skip to content

Feature/expense comments (Issue #61)#489

Closed
Himanshu9271 wants to merge 4 commits intooss-apps:mainfrom
Himanshu9271:feature/expense-comments
Closed

Feature/expense comments (Issue #61)#489
Himanshu9271 wants to merge 4 commits intooss-apps:mainfrom
Himanshu9271:feature/expense-comments

Conversation

@Himanshu9271
Copy link

@Himanshu9271 Himanshu9271 commented Nov 18, 2025

Description

Added the feature to add comments to expense
Closes #61

Demo

image

Checklist

  • I have read CONTRIBUTING.md in its entirety
  • I have performed a self-review of my own code
  • I have added unit tests to cover my changes
  • The last commit successfully passed pre-commit checks
  • Any AI code was thoroughly reviewed by me

@krokosik krokosik modified the milestone: 2.1 Feb 11, 2026
@krokosik
Copy link
Collaborator

Now that v2.0 is merged, I had the chance to go over the PR and while this is a good start, it is not yet ready for merging. The fact that the UI is completely unrelated to the rest of the repo and everything is crammed into a single component, makes it look like a one shot LLM prompt. There are fundamental issues like lack of Prisma relations setup, onDelete rules or the simple fact that you are inventing new markup and style instead of relying on our UI components.

All of this plus other LLM leftovers make me lean towards closing this PR as in violation of our AI policy, but if you are willing to put in the effort to polish this PR, let me know.

@Himanshu9271
Copy link
Author

Apologies for submiting a low quality PR. Admitedly it was my first time wokring with prisma and nextjs so I did rely on llms. I will try to polish and improve this. Please let me know if you have any feedback or suggestion.

@krokosik
Copy link
Collaborator

Thank you for your honesty. I hope it is understandable, but if you have no knowledge of nextjs or prisma then I am not going to accept a contribution from you, as it will be much more work for me to guide you than to ask an LLM myself.

@krokosik krokosik closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to add comments in an expense

2 participants