Skip to content

chore: update v2 thresholds#2638

Open
tricky42 wants to merge 1 commit into
masterfrom
abu/rate-limits-update-thresholds
Open

chore: update v2 thresholds#2638
tricky42 wants to merge 1 commit into
masterfrom
abu/rate-limits-update-thresholds

Conversation

@tricky42

@tricky42 tricky42 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Sync the rate-limit CSVs from cloud and regenerate rate-limits.json for the new v2 base limits: HydraPublicHigh / KratosAdminHigh increases plus the 50→60, 900→950, 800→850 ratchets.

Sync the rate-limit CSVs from cloud (ory-corp/cloud) and regenerate
rate-limits.json: HydraPublicHigh/KratosAdminHigh increases plus the
50->60 / 900->950 / 800->850 ratchets.
@tricky42 tricky42 requested review from aeneasr and vinckr as code owners June 21, 2026 22:46
Copilot AI review requested due to automatic review settings June 21, 2026 22:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the documentation site’s rate-limit dataset to match the latest v2 base limits synced from cloud, ensuring the RateLimitsTable and any downstream consumers display the current thresholds and endpoints.

Changes:

  • Updated bucket-to-threshold.csv with new v2 rate-limit thresholds (HydraPublicHigh, KratosAdminHigh, and the 50→60 / 900→950 / 800→850 ratchets).
  • Added GET /.well-known/change-password to the endpoint-to-bucket mapping.
  • Regenerated src/static/rate-limits.json from the CSV sources to reflect the new endpoints and thresholds.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/static/rate-limits.json Regenerated static rate-limit data consumed by the docs UI.
src/lib/rate-limits/data/bucket-to-threshold.csv Updates per-bucket limits for v2 tiers/environments.
src/lib/rate-limits/data/bucket-to-endpoints.csv Adds the new Kratos public endpoint mapping for change-password.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The entire src/static/rate-limits.json file is replaced. The endpoints array gains new method/path entries for Hydra, Kratos, Ory, Keto, Polis, and Talos services with updated bucket assignments, and the thresholds array gains new Talos bucket definitions and revised rpm/rps values across Developer, Enterprise, and Growth tiers for Development, Production, and Staging environments.

Changes

Rate Limits Configuration

Layer / File(s) Summary
Endpoint routes, bucket mappings, and threshold values
src/static/rate-limits.json
Full JSON replacement expanding endpoints with new method/path entries for Hydra, Kratos, Ory, Keto, Polis, and Talos, remapping route-to-bucket assignments, adding new Talos bucket definitions to thresholds, and adjusting rpm/rps numeric limits for multiple existing buckets across all tiers and environments.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • ory/docs#2460: Introduces the rate-limits table/plugin that directly consumes the src/static/rate-limits.json data modified in this PR, making the two changes directly connected at the data level.

Suggested labels

upstream

Suggested reviewers

  • aeneasr
  • zepatrik
  • wassimoo
  • vinckr
  • piotrmsc

Poem

🐇 Hopping through the JSON maze,
New buckets and routes I now trace,
Talos joins Kratos and Keto in line,
With rpm and rps redefined,
Rate limits? Now perfectly in place! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is very brief and lacks required template sections like 'Related Issue or Design Document' and the completion checklist. Add the missing template sections: include a link to the related design document or issue (e.g., #issue_number or ory-corp/cloud#12469), and complete the checklist items to confirm compliance with contributing guidelines, CLA, security policy, tests, and documentation requirements.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'chore: update v2 thresholds' is partially related to the changeset, referring to threshold updates, but it lacks specificity about the rate-limit configuration changes and doesn't clearly convey that this involves rate-limiting thresholds.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch abu/rate-limits-update-thresholds

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tricky42 tricky42 changed the title chore(rate-limits): update v2 thresholds chore: update v2 thresholds Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants