feat: ory.com#441
Conversation
|
Warning Review limit reached
More reviews will be available in 15 minutes and 14 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (19)
📝 WalkthroughWalkthroughThis PR updates all references to the ChangesDomain Migration from ory.sh to ory.com
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmd/cloudx/project/update_identity_config.go`:
- Around line 52-55: The help text contains URLs with trailing periods (e.g.
"https://www.ory.com/docs/reference/api#operation/updateProject.") which break
copy/paste; remove the trailing period from those URL strings in the command's
help/comment. Locate the help text in the updateIdentityConfig command (e.g.,
updateIdentityConfigCmd or UpdateIdentityConfig function) and edit the literal
URL(s) so they end with the domain/path only (no final "."), preserving
surrounding wording and punctuation.
In `@cmd/dev/newsletter/stub/changelog.html.expected`:
- Around line 1596-1599: Update the plaintext docs link in the newsletter
changelog HTML so it uses HTTPS: replace the anchor href and visible text
"http://ory.com/docs/kratos/next/guides/multi-domain-cookies" with
"https://ory.com/docs/kratos/next/guides/multi-domain-cookies" (the anchor
element inside the list item for the domain aliasing entry), and apply the same
change in the newsletter fixtures that generate the email and markdown preview
so both snapshots reflect the HTTPS URL.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 8ab960c5-7cf8-4b76-a78a-14ca5a0e4d26
📒 Files selected for processing (14)
cmd/cloudx/client/sdks.gocmd/cloudx/project/patch.gocmd/cloudx/project/patch_identity_config.gocmd/cloudx/project/patch_oauth2_config.gocmd/cloudx/project/patch_permission_config.gocmd/cloudx/project/update.gocmd/cloudx/project/update_identity_config.gocmd/cloudx/project/update_oauth2_config.gocmd/cloudx/project/update_permission_config.gocmd/dev/newsletter/.snapshots/TestRenderMarkdownLong.jsoncmd/dev/newsletter/draft.gocmd/dev/newsletter/stub/changelog.html.expectedcmd/dev/newsletter/stub/changelog.md.expectedview/mail-body.html
d0f45a4 to
5b395a6
Compare
Summary by CodeRabbit
Documentation
Chores