Skip to content

thin: guard keyword-value pair decode against empty payload bytes#588

Open
SAY-5 wants to merge 1 commit intooracle:mainfrom
SAY-5:say5/keyword-value-pairs-empty-587
Open

thin: guard keyword-value pair decode against empty payload bytes#588
SAY-5 wants to merge 1 commit intooracle:mainfrom
SAY-5:say5/keyword-value-pairs-empty-587

Conversation

@SAY-5
Copy link
Copy Markdown

@SAY-5 SAY-5 commented May 2, 2026

Fixes #587.

_process_keyword_value_pairs left text_value and binary_value as None whenever the server sent a zero-length payload, then unconditionally called text_value.decode() for TNS_KEYWORD_NUM_CURRENT_SCHEMA and TNS_KEYWORD_NUM_EDITION. ALTER PLUGGABLE DATABASE OPEN/CLOSE against 19c reproduces the path — the DDL succeeded server-side but the async client crashed in the response parser and left the connection unusable.

Add the obvious nil-guards on each branch (also on the TNS_KEYWORD_NUM_TRANSACTION_ID binary path).

Signed-off-by: SAY-5 <say.apm35@gmail.com>
@oracle-contributor-agreement
Copy link
Copy Markdown

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label May 2, 2026
@SAY-5
Copy link
Copy Markdown
Author

SAY-5 commented May 3, 2026

The failing oca/oracle check is the OCA contributor signature step; I will get that signed and rerun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thin async crashes with AttributeError: 'NoneType' object has no attribute 'decode' in _process_keyword_value_pairs

1 participant