Skip to content

[GR-75643] Restrict graalpytest worker socket to loopback. #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
graalvmbot wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

[GR-75643] Restrict graalpytest worker socket to loopback. #861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions graalpython/com.oracle.graal.python.test/src/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@

RUNNER_ENV = {}
DISABLE_JIT_ENV = {'GRAAL_PYTHON_VM_ARGS': '--experimental-options --engine.Compilation=false'}
# The worker transport sends pickled data, so keep it on loopback only.
WORKER_SERVER_HOST = '127.0.0.1'

GITHUB_CI = os.environ.get("GITHUB_CI", None)
if GITHUB_CI:
Expand Down Expand Up @@ -791,7 +793,7 @@ def run_in_subprocess_and_watch(self):
self.thread = threading.current_thread()
with (
tempfile.TemporaryDirectory(prefix='graalpytest-') as tmp_dir,
socket.create_server(('0.0.0.0', 0)) as server,
socket.create_server((WORKER_SERVER_HOST, 0)) as server,
):
tmp_dir = Path(tmp_dir)

Expand Down Expand Up @@ -1327,7 +1329,7 @@ def poll(self, timeout=None):


def main_worker(args):
with socket.create_connection(('localhost', args.port)) as sock:
with socket.create_connection((WORKER_SERVER_HOST, args.port)) as sock:
conn = Connection(sock)

tests = conn.recv()
Expand Down
Loading