-
Notifications
You must be signed in to change notification settings - Fork 9
docs: update incremental benchmarks (3.9.5) #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
carlos-alm
merged 4 commits into
main
from
benchmark/incremental-v3.9.5-20260423-233910
Apr 27, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
96bb79b
docs: update incremental benchmarks (3.9.5)
github-actions[bot] 538f1d7
Merge branch 'main' into benchmark/incremental-v3.9.5-20260423-233910
carlos-alm 0ad35f3
docs: note v3.9.5 engine-null cause in incremental benchmarks (#1008)
carlos-alm bdee7e3
Merge branch 'main' into benchmark/incremental-v3.9.5-20260423-233910
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3.9.5 JSON entry sets
"wasm": nulland"native": null, and the corresponding "Native (Rust)" and "WASM" tables were dropped from the rendered "Latest results" section entirely. This makes it impossible to track build-time regression across versions for these two execution targets. If the benchmark workflow failed to collect those measurements, the run should be investigated before merging this update.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. The root cause was that both the wasm and native workers hung past the 10-minute per-engine timeout (
scripts/lib/fork-engine.ts) during the 1-file rebuild phase and were killed with SIGKILL — see workflow run #770 logs. Import resolution still ran because it lives in the parent process. Added aNOTES_START/ENDblock to the "Latest results" section documenting the timeout and explaining why 3.9.5 is absent from the comparison table, mirroring how 3.5.0 was handled in #685.