Conversation
Owner
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 위젯(Heatmap, Today)의 하드코딩된 문자열을 현지화 키로 대체하고 Localizable.xcstrings 파일을 추가하는 작업을 포함합니다. 또한 Xcode 프로젝트 설정 및 스킴 업데이트가 이루어졌습니다. 리뷰 결과, 히트맵 위젯에서 요일 라벨(WidgetHeatmapWeekdayLabels)이 삭제되어 정보가 표시되지 않는 문제가 발견되었으며, 레이아웃 계산 로직에서도 해당 영역이 제외된 점을 수정해야 합니다. 더불어 Localizable.xcstrings 내 일부 키(Heatmap, Today)의 번역이 누락되어 보완이 필요합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
📝 작업 내용
📌 요약
위젯에 노출되는 고정 문자열의 위젯 전용 String Catalog 기반 현지화 적용
🔍 상세
DevLogWidget/Resource/Localizable.xcstrings추가📸 영상 / 이미지 (Optional)