Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 pull request는 위젯의 히트맵 placeholder 로직을 개선하고, 관련 단위 테스트들을 추가하여 안정성을 높였습니다. 특히 WidgetHeatmapPlaceholderShape를 도입하여 실제 날짜 위치에 기반한 placeholder를 생성하도록 변경되었습니다. 리뷰 결과, 테스트 코드의 중복을 줄이기 위한 fixture 개선과 placeholder 구현 시 가짜 데이터 모델 대신 메인 레이아웃 로직을 공유하도록 하는 구조적 개선 사항이 제안되었습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
📝 작업 내용
📌 요약
🔍 상세
Calendar.startOfQuarter(for:)extension 위치를 WidgetShared로 이동📸 영상 / 이미지 (Optional)