[#619] FCM Token을 해제하지 못할 시 로그아웃에 실패하는 현상을 해결한다#622
Merged
Conversation
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Owner
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 소셜 로그인 및 계정 연동 시 취소 처리를 에러 던지기 대신 Bool 또는 옵셔널 반환값으로 처리하도록 리팩토링하고, FCM 토큰 삭제 시의 에러 처리를 개선하였습니다. 리뷰어는 FCM 토큰 삭제 실패는 안전하게 처리되었으나, Firestore에서 FCM 토큰을 삭제하는 과정(infoRef.updateData)에서 에러가 발생할 경우 여전히 로그아웃 전체가 실패할 수 있으므로 이에 대한 추가적인 예외 처리를 권장하고 있습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
deleteToken()호출 생략🔍 상세
AuthenticationService.signIn()과link()가 취소 흐름을 표현할 수 있도록 결과 기반으로 조정messaging.fcmToken이 있을 때만 FCM 토큰 삭제 수행Auth.auth().signOut()은 계속 진행📸 영상 / 이미지 (Optional)