Make the color scheme chooser active theme check work.#3062
Open
drgrice1 wants to merge 1 commit into
Open
Conversation
In the HTML markup for the color scheme chooser in `templates/layouts/system.html.ep` each of the theme buttons in the dropdown have a check icon. However, that check icon has `d-none` set, and it is always that way. So the checks are never shown. The javascript is supposed to make the check for the active theme visible, but does not. So make that happen. This is a result of copying the HTML that Bootstrap actually uses for the theme chooser on their documentation page, and using the JavScript they demonstrate on their documentation page, but their implementation and their demonstration do not quite match.
pstaabp
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the HTML markup for the color scheme chooser in
templates/layouts/system.html.epeach of the theme buttons in the dropdown have a check icon. However, that check icon hasd-noneset, and it is always that way. So the checks are never shown. The javascript is supposed to make the check for the active theme visible, but does not. So make that happen.This is a result of copying the HTML that Bootstrap actually uses for the theme chooser on their documentation page, and using the JavScript they demonstrate on their documentation page, but their implementation and their demonstration do not quite match.