Preserve the entered answer when the "Show Correct Answers" button is used.#2918
Open
drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
Open
Preserve the entered answer when the "Show Correct Answers" button is used.#2918drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
Conversation
… used. This is a case that was missed in openwebwork#2855. At this point on the develop branch when the "Show Correct Answers" button is used, the form fields are not submitted to PG, and so the answer disappears. This is perhaps a minor issue as this is not the answer saved in the database, but just the answer entered at the time the "Show Correct Answers" button is used which won't be saved to the database anyway. However, it is a change in behavior. So this pull request just restores that prior behavior. Note that if there is an answer saved in the database, then that will replace what is submitted when the "Show Correct Answers" button is used anyway. That is how it was before, and that is the same with this.
drgrice1
force-pushed
the
bugfix/show-correct-preserve-answers
branch
from
2830117 to
3c1af12
Compare
somiaj
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a case that was missed in #2855. At this point on the develop branch when the "Show Correct Answers" button is used, the form fields are not submitted to PG, and so the answer disappears. This is perhaps a minor issue as this is not the answer saved in the database, but just the answer entered at the time the "Show Correct Answers" button is used which won't be saved to the database anyway. However, it is a change in behavior. So this pull request just restores that prior behavior.
Note that if there is an answer saved in the database, then that will replace what is submitted when the "Show Correct Answers" button is used anyway. That is how it was before, and that is the same with this.