Update the pgaux.t test for subtests and add some new#1428
Merged
Conversation
Alex-Jordan
reviewed
Jun 5, 2026
drgrice1
approved these changes
Jun 20, 2026
drgrice1
left a comment
drgrice1
left a comment
Member
There was a problem hiding this comment.
There is some code clean up needed, but the separation into subtests is nice.
Alex-Jordan
approved these changes
Jul 12, 2026
Alex-Jordan
left a comment
Alex-Jordan
left a comment
Contributor
There was a problem hiding this comment.
Marking for approval, but I won't merge given the unresolved comments.
rounding tests to prep for new rounding function.
pstaabp
force-pushed
the
update-pgaux-test
branch
from
July 14, 2026 14:16
1c64f73 to
2fb9ab8
Compare
Member
Author
|
Updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some new rounding test that will be updated with #1422. This also switches tests to subtest for organization.