Open
Conversation
dkalinowski
reviewed
May 7, 2026
dkalinowski
reviewed
May 7, 2026
dtrawins
reviewed
May 7, 2026
dkalinowski
reviewed
May 7, 2026
| } | ||
|
|
||
| TEST_P(HttpOpenAIHandlerCommonParsingValidationTest, SkipSpecialTokensDefaultIsTrue) { | ||
| std::string json = createRequestWithSkipSpecialTokensRawValue("true"); |
Collaborator
There was a problem hiding this comment.
this variable is never used
dkalinowski
reviewed
May 7, 2026
| std::optional<uint32_t> maxModelLength; | ||
| auto apiHandler = createHandler(endpoint(), "llama3"); | ||
|
|
||
| EXPECT_EQ(apiHandler->parseRequest(maxTokensLimit, bestOfLimit, maxModelLength), absl::OkStatus()); |
Collaborator
There was a problem hiding this comment.
EXPECT_EQ(apiHandler->getOutputParser(), nullptr);
shouldnt it be included?
and
EXPECT_NE(apiHandler->getOutputParser(), nullptr);
shouldnt it be included?
in the test above?
Collaborator
There was a problem hiding this comment.
what does it mean "accepted"?
dkalinowski
approved these changes
May 7, 2026
dtrawins
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addressing: #4168.
Works only in configuration without parsers (
skip_special_tokens=falserejected if model configuration specifiestool_parserorreasoning_parser).