Skip to content

Added eco-tests for indexer + CI job to notify the indexer team#2624

Open
evgeny-s wants to merge 7 commits into
devnet-readyfrom
eco-tests-indexers
Open

Added eco-tests for indexer + CI job to notify the indexer team#2624
evgeny-s wants to merge 7 commits into
devnet-readyfrom
eco-tests-indexers

Conversation

@evgeny-s
Copy link
Copy Markdown
Collaborator

@evgeny-s evgeny-s commented Apr 29, 2026

Description

This PR adds contract-style tests for the storage maps and runtime APIs consumed by the TAO.com indexer, plus a CI workflow that pings the responsible reviewer(-s) whenever those tests change. It detects storage items, renames, retypes, key shape changes, and runtime api signature changes.

Tested here.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

eco-tests changed — indexer review required

This PR modifies files under eco-tests/. and may affect downstream indexing.
cc @evgeny-s — please review manually

Changed files
  • eco-tests/Cargo.toml
  • eco-tests/src/lib.rs
  • eco-tests/src/mock.rs
  • eco-tests/src/tests_taocom_indexer.rs

@evgeny-s evgeny-s added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Apr 29, 2026
Comment thread eco-tests/src/tests_taocom_indexer.rs Outdated
Comment thread eco-tests/src/tests_taocom_indexer.rs
@evgeny-s evgeny-s requested a review from gztensor April 30, 2026 13:17
Comment thread eco-tests/src/tests_taocom_indexer.rs Outdated
Comment thread eco-tests/src/tests_taocom_indexer.rs Outdated
Comment thread eco-tests/src/tests_taocom_indexer.rs Outdated
Comment thread eco-tests/src/tests_taocom_indexer.rs Outdated
Comment thread eco-tests/src/tests_taocom_indexer.rs Outdated
Comment thread eco-tests/src/tests_taocom_indexer.rs Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

BASELINE scrutiny: established write-permission contributor, no Gittensor allowlist match found, PR #2624 targets devnet-ready from eco-tests-indexers.

Reviewed the CI workflow, eco-test dependency additions, and test-only runtime API mocks. The workflow uses write permissions only to maintain a sticky comment and request a fixed reviewer, does not use pull_request_target, and does not execute PR-controlled code beyond git diff --name-only. The added dependencies are already present in the workspace/lockfile sources and are scoped to eco-tests. No .github/ai-review/* or .github/copilot-instructions.md changes were present.

Findings

No findings.

Conclusion

No malicious behavior or security vulnerability was found in the diff. The changes are limited to a reviewer-notification workflow and test-only indexer contract coverage.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

LIKELY gittensor-associated / established write-permission contributor; no allowlist hit, but recent PR history is overwhelmingly in subtensor. Skeptic already cleared the workflow/security posture.

Auto-fix: applied rustfmt directly to eco-tests/src/lib.rs and eco-tests/src/tests_taocom_indexer.rs; those workspace changes are left for the follow-up auto-commit step. I attempted the targeted cargo test -p eco-tests tests_taocom_indexer -- --nocapture, but this sandbox cannot write to /home/runner/.rustup or /home/runner/.cargo, so dependency/toolchain setup failed before compilation. Static review found no domain-blocking issues in the test-only indexer contract coverage or notification workflow.

Findings

No findings.

Conclusion

The PR is scoped to eco-test coverage plus a reviewer notification workflow, with no runtime behavior change and no spec-version bump required. After the formatting auto-fix, I found no substantive issues blocking merge.

@github-actions
Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants