Skip to content

Consume common templates via CommonTemplates field#378

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fmount:templates
May 29, 2026
Merged

Consume common templates via CommonTemplates field#378
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fmount:templates

Conversation

@fmount
Copy link
Copy Markdown
Contributor

@fmount fmount commented May 18, 2026 •
edited
Loading

The ssl.conf httpd configuration is duplicated across service operators.
This patch removes the local copy and consumes it from lib-common.

Jira: OSPRH-30239

@fmount fmount requested review from abays, amoralej and stuggi May 18, 2026 15:12
@openshift-ci openshift-ci Bot requested a review from dprince May 18, 2026 15:12
@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 18, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/5b0ec9c0c6624c1795b437c254c91a60

✔️ openstack-meta-content-provider-master SUCCESS in 3h 14m 37s
❌ watcher-operator-validation-master FAILURE in 2h 16m 45s
✔️ openstack-meta-content-provider-epoxy SUCCESS in 2h 56m 53s
❌ watcher-operator-validation-epoxy FAILURE in 1h 50m 09s
✔️ watcher-operator-validation-epoxy-ocp4-18 SUCCESS in 2h 00m 55s
✔️ noop SUCCESS in 0s
✔️ watcher-operator-kuttl SUCCESS in 57m 26s

@fmount
Copy link
Copy Markdown
Contributor Author

fmount commented May 19, 2026

recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 19, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/9ca4eb3242cf4bc2adb0e81688a95135

✔️ openstack-meta-content-provider-master SUCCESS in 2h 46m 45s
❌ watcher-operator-validation-master FAILURE in 1h 42m 57s
✔️ openstack-meta-content-provider-epoxy SUCCESS in 2h 54m 32s
❌ watcher-operator-validation-epoxy POST_FAILURE in 1h 50m 11s
✔️ watcher-operator-validation-epoxy-ocp4-18 SUCCESS in 1h 58m 54s
✔️ noop SUCCESS in 0s
❌ watcher-operator-kuttl FAILURE in 1h 23m 50s

@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 20, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/cee22b2365d54098a1de74ec007dde32

✔️ openstack-meta-content-provider-master SUCCESS in 1h 05m 47s
❌ watcher-operator-validation-master FAILURE in 24m 38s
❌ openstack-meta-content-provider-epoxy FAILURE in 8m 26s
⚠️ watcher-operator-validation-epoxy SKIPPED Skipped due to failed job openstack-meta-content-provider-epoxy
⚠️ watcher-operator-validation-epoxy-ocp4-18 SKIPPED Skipped due to failed job openstack-meta-content-provider-epoxy
✔️ noop SUCCESS in 0s
❌ watcher-operator-kuttl RETRY_LIMIT in 20m 28s

@fmount
Copy link
Copy Markdown
Contributor Author

fmount commented May 25, 2026

recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 25, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/69acf32bbd1849ddb2a8fc613751c3e1

✔️ openstack-meta-content-provider-master SUCCESS in 2h 23m 28s
❌ watcher-operator-validation-master FAILURE in 1h 44m 55s
✔️ openstack-meta-content-provider-epoxy SUCCESS in 2h 22m 14s
✔️ watcher-operator-validation-epoxy SUCCESS in 2h 00m 56s
✔️ watcher-operator-validation-epoxy-ocp4-18 SUCCESS in 2h 00m 29s
✔️ noop SUCCESS in 0s
❌ watcher-operator-kuttl FAILURE in 1h 12m 36s

@amoralej
Copy link
Copy Markdown
Contributor

amoralej commented May 25, 2026

#369 is needed to unblock the gate

@fmount
Consume common templates via CommonTemplates field
80d346c 
Remove duplicated templates from the operator and consume them
from lib-common via the CommonTemplates field. This allows
maintaining common configuration files (e.g. ssl.conf) in a
single location across all operators.

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 28, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/1f5643f4279747889ac77e2a93946c68

✔️ openstack-meta-content-provider-master SUCCESS in 2h 12m 45s
❌ watcher-operator-validation-master RETRY_LIMIT in 29s
✔️ openstack-meta-content-provider-epoxy SUCCESS in 2h 46m 05s
✔️ watcher-operator-validation-epoxy SUCCESS in 1h 57m 49s
✔️ watcher-operator-validation-epoxy-ocp4-18 SUCCESS in 2h 01m 13s
✔️ noop SUCCESS in 0s
✔️ watcher-operator-kuttl SUCCESS in 1h 00m 34s

@fmount
Copy link
Copy Markdown
Contributor Author

fmount commented May 28, 2026

recheck

@openshift-ci openshift-ci Bot added the lgtm label May 29, 2026
@raukadah
Copy link
Copy Markdown
Contributor

raukadah commented May 29, 2026

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 5126172 into openstack-k8s-operators:main May 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amoralej amoralej amoralej approved these changes

@abays abays Awaiting requested review from abays

@stuggi stuggi Awaiting requested review from stuggi

@dprince dprince Awaiting requested review from dprince

Assignees

@amoralej amoralej

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fmount @amoralej @raukadah