Skip to content

Fix AnsibleEE job name collisions for long names #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
holser wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −13
Open

Fix AnsibleEE job name collisions for long names #1819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions internal/dataplane/util/ansible_execution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ package util //nolint:revive // util is an acceptable package name in this conte

import (
"context"
"crypto/sha256"
"encoding/hex"
"encoding/json"
"fmt"
"sort"
Expand Down Expand Up @@ -167,29 +169,23 @@ func GetAnsibleExecution(ctx context.Context,
return ansibleEE, nil
}

// getAnsibleExecutionNamePrefix compute the name of the AnsibleEE
func getAnsibleExecutionNamePrefix(serviceName string) string {
AnsibleExecutionServiceNameLen := apimachineryvalidation.DNS1123LabelMaxLength - 10

if len(serviceName) > AnsibleExecutionServiceNameLen {
return serviceName[:AnsibleExecutionServiceNameLen]
}

return serviceName
}

// GetAnsibleExecutionNameAndLabels Name and Labels of AnsibleEE
func GetAnsibleExecutionNameAndLabels(service *dataplanev1.OpenStackDataPlaneService,
deploymentName string,
nodeSetName string,
) (string, map[string]string) {
executionName := fmt.Sprintf("%s-%s", getAnsibleExecutionNamePrefix(service.Name), deploymentName)
executionName := fmt.Sprintf("%s-%s", service.Name, deploymentName)
if !service.Spec.DeployOnAllNodeSets {
executionName = fmt.Sprintf("%s-%s", executionName, nodeSetName)
}

if len(executionName) > apimachineryvalidation.DNS1123LabelMaxLength {
executionName = strings.TrimRight(executionName[:apimachineryvalidation.DNS1123LabelMaxLength], "-.")
hash := sha256.Sum256([]byte(executionName))
hashSuffix := hex.EncodeToString(hash[:])[:8]
Copy link
Contributor

@rabi rabi Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not guranteed to be unique either, but the conflict probability is much less.

// 9 = "-" + 8 char hash suffix
maxPrefix := apimachineryvalidation.DNS1123LabelMaxLength - 9
prefix := strings.TrimRight(executionName[:maxPrefix], "-.")
executionName = fmt.Sprintf("%s-%s", prefix, hashSuffix)
}

labels := map[string]string{
Expand Down