Skip to content

ensure the cluster pod placement config resource is under the cluster whitelist in app project#79906

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
droslean:argo-10
Jun 1, 2026
Merged

ensure the cluster pod placement config resource is under the cluster whitelist in app project#79906
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
droslean:argo-10

Conversation

@droslean
Copy link
Copy Markdown
Member

@droslean droslean commented Jun 1, 2026

Summary by CodeRabbit

This PR updates the Argo AppProject configuration for OpenShift CI's build clusters to properly authorize management of cluster pod placement resources.

Change: The clusterResourceWhitelist in clusters/gitops/apps/appproject-build-clusters-common.yaml has been reorganized to include the multiarch.openshift.io/ClusterPodPlacementConfig resource, positioning it after the security.openshift.io/SecurityContextConstraints entry.

Impact: This addition to the cluster resource whitelist enables the Argo GitOps automation to deploy and manage multi-architecture pod placement configurations across the build cluster infrastructure (build01 through build13). The ClusterPodPlacementConfig resource controls pod scheduling policies for multi-architecture workloads in the OpenShift CI environment.

… whitelist in app project

Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 1, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@droslean: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 21065cdb-5346-4efe-9214-4e89f071cbd0

📥 Commits

Reviewing files that changed from the base of the PR and between 0c2f5b6 and 9b978ef.

📒 Files selected for processing (1)
  • clusters/gitops/apps/appproject-build-clusters-common.yaml

Walkthrough

The clusterResourceWhitelist in appproject-build-clusters-common.yaml is reordered to relocate the multiarch.openshift.io ClusterPodPlacementConfig entry to an earlier position in the list, immediately following the security.openshift.io SecurityContextConstraints entry.

Changes

AppProject Resource Allowlist Reordering

Layer / File(s) Summary
ClusterPodPlacementConfig allowlist entry repositioning
clusters/gitops/apps/appproject-build-clusters-common.yaml
The multiarch.openshift.io ClusterPodPlacementConfig entry in clusterResourceWhitelist is moved earlier in the list to immediately follow the security.openshift.io SecurityContextConstraints entry, removing it from its previous position later in the sequence.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openshift/release#79875: Expands the AppProject's permissions for ClusterPodPlacementConfig in the same manifest file, directly related to this allowlist reordering.

Suggested labels

lgtm

Suggested reviewers

  • smg247
  • jmguzik
  • deepsm007
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: relocating the ClusterPodPlacementConfig resource entry in the clusterResourceWhitelist within the app project YAML manifest.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Custom check for Ginkgo test names is not applicable; PR modifies only YAML configuration file (appproject-build-clusters-common.yaml), not test code.
Test Structure And Quality ✅ Passed PR contains only YAML manifest changes with no Ginkgo test code, making the check for Ginkgo test quality not applicable.
Microshift Test Compatibility ✅ Passed PR only modifies YAML manifest (appproject-build-clusters-common.yaml). No Ginkgo e2e tests are added, so MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR contains only YAML manifest changes to an ArgoCD AppProject file, with no Ginkgo e2e tests added. Custom check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed ArgoCD AppProject configuration file added with no scheduling constraints, pod affinity rules, topology spread constraints, node selectors, or replica counts.
Ote Binary Stdout Contract ✅ Passed PR modifies only a YAML manifest file; OTE Binary Stdout Contract check applies only to Go process-level code, which is not present in this change.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only YAML configuration (appproject-build-clusters-common.yaml), not Ginkgo e2e tests. Custom check requires new e2e tests; check is not applicable.
No-Weak-Crypto ✅ Passed PR modifies only a YAML manifest file for ArgoCD AppProject configuration with no cryptographic code, weak crypto, or secret comparisons present.
Container-Privileges ✅ Passed ArgoCD AppProject manifest listing whitelisted resources. No container specs, privileged mode, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings present.
No-Sensitive-Data-In-Logs ✅ Passed PR is a YAML manifest reordering with no logging code or sensitive data exposure; the check is not applicable to this declarative configuration change.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from deepsm007 and psalajova June 1, 2026 09:13
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2026
@danilo-gemoli
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, droslean, Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@droslean
Copy link
Copy Markdown
Member Author

droslean commented Jun 1, 2026

/override ci/prow/sync-rover-groups
/override ci/prow/owner
/override ci/prow/release-controller-config

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2026

@droslean: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow/owner

Only the following failed contexts/checkruns were expected:

  • CodeRabbit
  • ci/prow/core-valid
  • ci/prow/openshift-image-mirror-mappings
  • ci/prow/owners
  • ci/prow/release-controller-config
  • ci/prow/sync-rover-groups
  • ci/prow/yamllint
  • pull-ci-openshift-release-main-core-valid
  • pull-ci-openshift-release-main-owners
  • pull-ci-openshift-release-main-release-controller-config
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-sync-rover-groups
  • pull-ci-openshift-release-yamllint
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ci/prow/sync-rover-groups
/override ci/prow/owner
/override ci/prow/release-controller-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@droslean
Copy link
Copy Markdown
Member Author

droslean commented Jun 1, 2026

/override ci/prow/release-controller-config

@droslean
Copy link
Copy Markdown
Member Author

droslean commented Jun 1, 2026

/override ci/prow/owners

@droslean
Copy link
Copy Markdown
Member Author

droslean commented Jun 1, 2026

/override ci/prow/sync-rover-groups

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2026

@droslean: Overrode contexts on behalf of droslean: ci/prow/release-controller-config

Details

In response to this:

/override ci/prow/release-controller-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2026

@droslean: Overrode contexts on behalf of droslean: ci/prow/owners

Details

In response to this:

/override ci/prow/owners

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2026

@droslean: Overrode contexts on behalf of droslean: ci/prow/sync-rover-groups

Details

In response to this:

/override ci/prow/sync-rover-groups

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 9fc9dcf into openshift:main Jun 1, 2026
8 checks passed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2026

@droslean: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@droslean droslean deleted the argo-10 branch June 1, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants