ensure the cluster pod placement config resource is under the cluster whitelist in app project#79906
Conversation
… whitelist in app project Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe ChangesAppProject Resource Allowlist Reordering
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, droslean, Prucek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/sync-rover-groups |
|
@droslean: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/release-controller-config |
|
/override ci/prow/owners |
|
/override ci/prow/sync-rover-groups |
|
@droslean: Overrode contexts on behalf of droslean: ci/prow/release-controller-config DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@droslean: Overrode contexts on behalf of droslean: ci/prow/owners DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@droslean: Overrode contexts on behalf of droslean: ci/prow/sync-rover-groups DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@droslean: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary by CodeRabbit
This PR updates the Argo AppProject configuration for OpenShift CI's build clusters to properly authorize management of cluster pod placement resources.
Change: The
clusterResourceWhitelistinclusters/gitops/apps/appproject-build-clusters-common.yamlhas been reorganized to include themultiarch.openshift.io/ClusterPodPlacementConfigresource, positioning it after thesecurity.openshift.io/SecurityContextConstraintsentry.Impact: This addition to the cluster resource whitelist enables the Argo GitOps automation to deploy and manage multi-architecture pod placement configurations across the build cluster infrastructure (build01 through build13). The
ClusterPodPlacementConfigresource controls pod scheduling policies for multi-architecture workloads in the OpenShift CI environment.