test oidc ci#79901
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
the
needs-rebase
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughSets FEATURE_GATES and FEATURE_SET in two cluster-authentication-operator periodics and adds test steps in two hypershift E2E jobs that patch the FeatureGate to enable ExternalOIDCExternalClaimsSourcing, print a propagation message, and sleep 60 seconds. ChangesExternal OIDC rehearsal waits
🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels: Suggested reviewers:
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@gangwgr, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
openshift-ci
Bot
removed
the
needs-rebase
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-azure-aks-external-oidc-techpreview |
|
@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse e2e-aws-external-oidc-techpreview |
|
@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@gangwgr: job(s): pull-ci-openshift-hypershift-main-e2e-azure-aks-external-oidc-techpreview either don't exist or were not found to be affected, and cannot be rehearsed |
|
@gangwgr: job(s): e2e-aws-external-oidc-techpreview either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-azure-aks-external-oidc-techpreview |
|
@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-external-oidc-techpreview |
|
@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gangwgr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-azure-external-oidc-configure |
|
@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-azure-external-oidc-upstream-parity |
|
@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-5.0__periodics.yaml`:
- Around line 59-63: The wait step logs "Sleeping 60m for debugging..." but
calls sleep 60 (seconds); update the sleep command in the test step block (the
"- as: wait" commands that echo "Sleeping 60m...") to sleep 3600 to actually
pause 60 minutes (or change the echoed message to match the 60-second sleep if
shorter delay intended); apply the same change to the other occurrence of the "-
as: wait" block with the identical echo/sleep pair.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 246839c0-ebae-4273-9234-2d9b65338a5a
📒 Files selected for processing (2)
ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-5.0__periodics.yamlci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
| test: | ||
| - as: wait | ||
| commands: | | ||
| echo "Sleeping 60m for debugging..." | ||
| sleep 60 |
There was a problem hiding this comment.
Wait duration is incorrect for the stated 60-minute pause.
Both new wait steps log Sleeping 60m... but run sleep 60 (60 seconds). If the intent is a 60-minute rehearsal/debug delay, this currently under-waits by 59 minutes.
Proposed fix
- as: wait
commands: |
echo "Sleeping 60m for debugging..."
- sleep 60
+ sleep 3600Also applies to: 358-362
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-5.0__periodics.yaml`
around lines 59 - 63, The wait step logs "Sleeping 60m for debugging..." but
calls sleep 60 (seconds); update the sleep command in the test step block (the
"- as: wait" commands that echo "Sleeping 60m...") to sleep 3600 to actually
pause 60 minutes (or change the echoed message to match the 60-second sleep if
shorter delay intended); apply the same change to the other occurrence of the "-
as: wait" block with the identical echo/sleep pair.
|
/pj-rehearse periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-azure-external-oidc-configure |
|
@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-azure-external-oidc-configure |
|
@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-azure-external-oidc-upstream-parity |
|
@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@gangwgr: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-azure-external-oidc-upstream-parity |
|
@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-azure-external-oidc-configure |
|
@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
1 participant
Summary by CodeRabbit
This PR updates OpenShift CI configuration in the openshift/release repository to prepare several external OIDC E2E jobs to run with the ExternalOIDCExternalClaimsSourcing feature enabled.
What changed practically
openshift/hypershift CI operator config (ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml):
openshift/cluster-authentication-operator periodics (ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-5.0__periodics.yaml):
Practical effect
Lines changed: +34/-1 (approx). Estimated review effort: Medium.