Add hubs deployment ibu lane#79893
Conversation
|
Warning Review limit reached
More reviews will be available in 20 minutes and 6 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
WalkthroughAdds an eco-ci-cd CI config and telcov10n IBU workflow for CNF-RAN on OCP 4.20, plus seed and target hub deploy steps with scripts, step refs/metadata, and OWNERS; deploy steps build Ansible inventory, run deploy-ocp-sno.yml, and export cluster versions and inventory artifacts. ChangesIBU Test Workflow and Infrastructure Setup
Sequence Diagram(s)sequenceDiagram
participant Scheduler
participant IBU_Workflow
participant SeedDeployStep
participant TargetDeployStep
participant Ansible
participant Seed_Bastion
participant Target_Bastion
Scheduler->>IBU_Workflow: trigger `telcov10n-functional-cnf-ran-ibu`
IBU_Workflow->>SeedDeployStep: run seed deploy
SeedDeployStep->>Ansible: run deploy-ocp-sno.yml (inventory)
Ansible->>Seed_Bastion: provision seed hub
IBU_Workflow->>TargetDeployStep: run target deploy
TargetDeployStep->>Ansible: run deploy-ocp-sno.yml (inventory)
Ansible->>Target_Bastion: provision target hub
IBU_Workflow->>Scheduler: run IBU tests & post reporting
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-4.20-cnf-ran-ztp-tests |
|
@shaior: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
ci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-seed-hub-deploy/telcov10n-functional-cnf-ran-ibu-seed-hub-deploy-ref.yaml (1)
17-48: 💤 Low valueHardcoded
kni-qe-108credential mounts are coupled to theSEED_CLUSTER_NAMEdefault.
SEED_CLUSTER_NAMEis overridable, but the credentialname/mount_pathentries hardcodekni-qe-108. OverridingSEED_CLUSTER_NAMEwithout matching credentials would silently mount the wrong host variables. Worth a brief comment noting these must be updated together, or document that the cluster name is effectively fixed for this step.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-seed-hub-deploy/telcov10n-functional-cnf-ran-ibu-seed-hub-deploy-ref.yaml` around lines 17 - 48, The SEED_CLUSTER_NAME default is overridable but the credentials entries hardcode "kni-qe-108" (e.g., names like telcov10n-ansible-kni-qe-108-master0, telcov10n-ansible-kni-qe-108-bastion and mount_path entries under /var/host_variables/kni-qe-108/*), so changing SEED_CLUSTER_NAME will leave mounts mismatched; fix by parameterizing those credential name and mount_path values to use SEED_CLUSTER_NAME (or the template variable used by the pipeline) instead of the literal "kni-qe-108" (or if parameterization isn’t practical, add a clear top-of-file comment next to SEED_CLUSTER_NAME stating that all credential `name` and `mount_path` entries (telcov10n-ansible-kni-qe-108-*, /var/host_variables/kni-qe-108/*, /var/group_variables/kni-qe-108/*) must be updated when SEED_CLUSTER_NAME is changed).ci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-seed-hub-deploy/telcov10n-functional-cnf-ran-ibu-seed-hub-deploy-commands.sh (1)
86-94: 💤 Low valueRemove the temporary SSH private key after use.
The key is materialized at
/tmp/temp_ssh_keyand never deleted. Even in an ephemeral CI container, cleaning it up immediately after the SSH call is cheap hygiene and avoids it lingering for any later step sharing the filesystem.🧹 Suggested cleanup
CLUSTER_VERSION=$(ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null \ -i /tmp/temp_ssh_key "${BASTION_USER}@${BASTION_IP}" \ "KUBECONFIG=${HUB_KUBECONFIG} oc get clusterversion version -ojsonpath='{.status.desired.version}'") +rm -f /tmp/temp_ssh_key🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-seed-hub-deploy/telcov10n-functional-cnf-ran-ibu-seed-hub-deploy-commands.sh` around lines 86 - 94, The temporary SSH key file /tmp/temp_ssh_key is created and used by the ssh command that sets CLUSTER_VERSION but is never removed; after the ssh call (the command that populates CLUSTER_VERSION via KUBECONFIG=${HUB_KUBECONFIG} oc get clusterversion ...) remove the temp file (e.g., delete /tmp/temp_ssh_key) and ensure removal happens even on failure (use a trap or cleanup step) so the key is not left on disk after the script runs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-seed-hub-deploy/telcov10n-functional-cnf-ran-ibu-seed-hub-deploy-commands.sh`:
- Line 38: Replace the bare mkdir calls that can fail when directories already
exist with idempotent mkdir -p invocations; locate the mkdir
"/eco-ci-cd/inventories/ocp-deployment/group_vars" (and the similar mkdir at the
other occurrence) in
telcov10n-functional-cnf-ran-ibu-seed-hub-deploy-commands.sh and update them to
use mkdir -p so the script does not abort under set -e when the directory
already exists.
In
`@ci-operator/step-registry/telcov10n/functional/cnf-ran/ibu/telcov10n-functional-cnf-ran-ibu-workflow.yaml`:
- Around line 3-13: The workflow documentation claims it runs the IBU upgrade,
post-upgrade eco-gotests, Slack notification and job chaining, but the steps
section only defines pre with refs
telcov10n-functional-cnf-ran-ibu-seed-hub-deploy and
telcov10n-functional-cnf-ran-ibu-target-hub-deploy; either update the
documentation to state this is currently only a deployment lane, or add the
missing test and post blocks (e.g., include refs for the upgrade/test steps such
as telcov10n-functional-cnf-ran-ibu-upgrade and
telcov10n-functional-cnf-ran-ibu-post-upgrade-notify or whatever the canonical
job refs are) so the YAML's steps match the described Test and Post phases.
---
Nitpick comments:
In
`@ci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-seed-hub-deploy/telcov10n-functional-cnf-ran-ibu-seed-hub-deploy-commands.sh`:
- Around line 86-94: The temporary SSH key file /tmp/temp_ssh_key is created and
used by the ssh command that sets CLUSTER_VERSION but is never removed; after
the ssh call (the command that populates CLUSTER_VERSION via
KUBECONFIG=${HUB_KUBECONFIG} oc get clusterversion ...) remove the temp file
(e.g., delete /tmp/temp_ssh_key) and ensure removal happens even on failure (use
a trap or cleanup step) so the key is not left on disk after the script runs.
In
`@ci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-seed-hub-deploy/telcov10n-functional-cnf-ran-ibu-seed-hub-deploy-ref.yaml`:
- Around line 17-48: The SEED_CLUSTER_NAME default is overridable but the
credentials entries hardcode "kni-qe-108" (e.g., names like
telcov10n-ansible-kni-qe-108-master0, telcov10n-ansible-kni-qe-108-bastion and
mount_path entries under /var/host_variables/kni-qe-108/*), so changing
SEED_CLUSTER_NAME will leave mounts mismatched; fix by parameterizing those
credential name and mount_path values to use SEED_CLUSTER_NAME (or the template
variable used by the pipeline) instead of the literal "kni-qe-108" (or if
parameterization isn’t practical, add a clear top-of-file comment next to
SEED_CLUSTER_NAME stating that all credential `name` and `mount_path` entries
(telcov10n-ansible-kni-qe-108-*, /var/host_variables/kni-qe-108/*,
/var/group_variables/kni-qe-108/*) must be updated when SEED_CLUSTER_NAME is
changed).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 051836f9-863f-4f43-a165-4bc586e8d1c3
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (12)
ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-ibu-4.20.yamlci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-seed-hub-deploy/OWNERSci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-seed-hub-deploy/telcov10n-functional-cnf-ran-ibu-seed-hub-deploy-commands.shci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-seed-hub-deploy/telcov10n-functional-cnf-ran-ibu-seed-hub-deploy-ref.metadata.jsonci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-seed-hub-deploy/telcov10n-functional-cnf-ran-ibu-seed-hub-deploy-ref.yamlci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-target-hub-deploy/OWNERSci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-target-hub-deploy/telcov10n-functional-cnf-ran-ibu-target-hub-deploy-commands.shci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-target-hub-deploy/telcov10n-functional-cnf-ran-ibu-target-hub-deploy-ref.metadata.jsonci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-target-hub-deploy/telcov10n-functional-cnf-ran-ibu-target-hub-deploy-ref.yamlci-operator/step-registry/telcov10n/functional/cnf-ran/ibu/OWNERSci-operator/step-registry/telcov10n/functional/cnf-ran/ibu/telcov10n-functional-cnf-ran-ibu-workflow.metadata.jsonci-operator/step-registry/telcov10n/functional/cnf-ran/ibu/telcov10n-functional-cnf-ran-ibu-workflow.yaml
| echo "SEED_HUB_VERSION=${SEED_HUB_VERSION}" | ||
|
|
||
| echo "Processing common group_vars" | ||
| mkdir /eco-ci-cd/inventories/ocp-deployment/group_vars |
There was a problem hiding this comment.
Use mkdir -p to avoid a hard failure when the directory already exists.
With set -e, a bare mkdir aborts the whole step if group_vars/host_vars already exist in the eco-ci-cd inventory tree (e.g. on a retry or if the repo ships these dirs). -p makes this idempotent.
🛠️ Proposed fix
-mkdir /eco-ci-cd/inventories/ocp-deployment/group_vars
+mkdir -p /eco-ci-cd/inventories/ocp-deployment/group_vars-mkdir /eco-ci-cd/inventories/ocp-deployment/host_vars
+mkdir -p /eco-ci-cd/inventories/ocp-deployment/host_varsAlso applies to: 52-52
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/telcov10n/functional/cnf-ran/ibu-seed-hub-deploy/telcov10n-functional-cnf-ran-ibu-seed-hub-deploy-commands.sh`
at line 38, Replace the bare mkdir calls that can fail when directories already
exist with idempotent mkdir -p invocations; locate the mkdir
"/eco-ci-cd/inventories/ocp-deployment/group_vars" (and the similar mkdir at the
other occurrence) in
telcov10n-functional-cnf-ran-ibu-seed-hub-deploy-commands.sh and update them to
use mkdir -p so the script does not abort under set -e when the directory
already exists.
| documentation: |- | ||
| IBU (Image Based Upgrade) workflow for CNF RAN testing. | ||
| Pre: deploy seed hub (kni-qe-108) at SEED_HUB_VERSION and target hub (kni-qe-109) at TARGET_HUB_VERSION. | ||
| Test: run IBU upgrade and post-upgrade eco-gotests, report results. | ||
| Post: notify Slack, trigger next job in chain. | ||
| steps: | ||
| pre: | ||
| # Seed hub setup — kni-qe-108 deployed at SEED_HUB_VERSION (upgrade destination) | ||
| - ref: telcov10n-functional-cnf-ran-ibu-seed-hub-deploy | ||
| # Target hub setup — kni-qe-109 deployed at TARGET_HUB_VERSION (upgrade source), manages spokes | ||
| - ref: telcov10n-functional-cnf-ran-ibu-target-hub-deploy |
There was a problem hiding this comment.
Documentation describes Test/Post phases that the workflow does not implement.
The documentation states the workflow runs the IBU upgrade + post-upgrade eco-gotests and then notifies Slack / chains the next job, but steps only defines pre with the two hub-deploy refs — there is no test or post block. As written, this workflow only provisions the hubs and runs no test, so any job using it will pass without exercising IBU. If this "deployment lane" is intentional for now, trim the documentation to match; otherwise the test/post steps are missing.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/telcov10n/functional/cnf-ran/ibu/telcov10n-functional-cnf-ran-ibu-workflow.yaml`
around lines 3 - 13, The workflow documentation claims it runs the IBU upgrade,
post-upgrade eco-gotests, Slack notification and job chaining, but the steps
section only defines pre with refs
telcov10n-functional-cnf-ran-ibu-seed-hub-deploy and
telcov10n-functional-cnf-ran-ibu-target-hub-deploy; either update the
documentation to state this is currently only a deployment lane, or add the
missing test and post blocks (e.g., include refs for the upgrade/test steps such
as telcov10n-functional-cnf-ran-ibu-upgrade and
telcov10n-functional-cnf-ran-ibu-post-upgrade-notify or whatever the canonical
job refs are) so the YAML's steps match the described Test and Post phases.
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-4.20-cnf-ran-ztp-tests |
|
@shaior: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-4.20-cnf-ran-ztp-tests |
|
@shaior: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-4.20-cnf-ran-ztp-tests |
|
@shaior: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-4.20-cnf-ran-ztp-tests |
|
@shaior: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-4.20-cnf-ran-ztp-tests |
|
@shaior: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-4.20-cnf-ran-ztp-tests |
|
@shaior: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-4.20-cnf-ran-ztp-tests |
|
@shaior: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@shaior, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@shaior, If the problem persists, please contact Test Platform. |
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-4.20-cnf-ran-ztp-tests |
|
@shaior: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest required |
|
/test all |
|
/approve |
|
/pj-rehearse ack |
|
@shaior: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaior The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@shaior: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@shaior, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
1 similar comment
|
@shaior, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Add IBU (Image Based Upgrade) CI lane for CNF RAN testing. Deploys seed hub (kni-qe-108) at 4.20 and target hub (kni-qe-109) at 4.18. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@shaior, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@shaior: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary by CodeRabbit
This PR adds a new CNF RAN IBU (Image Based Upgrade) lane and the required step-registry pieces to OpenShift CI so the eco-ci-cd pipeline can deploy two hubs (seed + target) and run an IBU validation flow.
What changed (practical impact)
CI job config
Workflow
Step-registry entries (telcov10n/functional/cnf-ran/ibu)
Ownership and metadata
Why this matters
Notes / behavior details