OSDOCS-20668: Fix product name in Helm CLI release note#115363
Conversation
|
@jseseCCS: This pull request references OSDOCS-20668 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Thu Jul 16 19:24:37 - Prow CI generated the docs preview: |
|
@mkumku thanks for your review and comments! I made the update this time, but I need to flag something for going forward: After a release note has been through review and approved, we should reserve off-cycle changes for things that are genuinely new or have changed since release (behavior update, something that's since become inaccurate, etc.) rather than edits to content that was already signed off on. If something comes up post-release that falls into the "missed in review" bucket and not the "actually changed" bucket, we should queue it for the next content review cycle instead. Just want to make sure we've got a consistent process as this comes up more. Thanks for understanding. cc @opayne1 |
Completely understood. I don't know why I missed the review - I think I was on PTO while this was happening. Apologies about this. And this is a new product and a new product name, probably needed more attention from me to confirm the final text past the text provided in the jira. |
|
/lgtm |
webbnh
left a comment
There was a problem hiding this comment.
I just have one suggestion; otherwise...
/lgtm
|
/lgtm |
|
@jseseCCS: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
LGTM. Thank you! |
|
/label merge-review-needed |
|
Note to Merge Reviewer: This has @opayne1 's OK for publishing this now after SME and QE approvals. |
|
@mburke5678 thank you!! |
Version(s): 4.22
Issue: https://redhat.atlassian.net/browse/OSDOCS-20668
Link to docs preview:
QE review: 2 engineers and product manager approved. Recently this has been sufficient for a "QE" review.
Additional information: