OSDOCS-19838: add external id feature#112301
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jldohmann: This pull request references OSDOCS-19838 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
size/M
jldohmann
force-pushed
the
OSDOCS-19557
branch
6 times, most recently
from
6b71543 to
38fb2c5
Compare
jldohmann
force-pushed
the
OSDOCS-19557
branch
4 times, most recently
from
bd88ddb to
fc9948f
Compare
jldohmann
force-pushed
the
OSDOCS-19557
branch
2 times, most recently
from
c62e57c to
84e24e1
Compare
bhardesty
left a comment
bhardesty
left a comment
There was a problem hiding this comment.
This looks great! I just had a couple tiny suggestions.
| @@ -35,6 +35,11 @@ For {product-title} clusters, you must create the following account-wide roles a | |||
|
|
|||
| |=== | |||
| + | |||
| [IMPORTANT] | |||
| ==== | |||
| For enhanced security, it is recommended to include an external ID within the trust policies of the Support and Installer account-wide roles. For more information, see _About external ID_. | |||
There was a problem hiding this comment.
Suggestion: if RH recommends something, just tell users to do it.
| For enhanced security, it is recommended to include an external ID within the trust policies of the Support and Installer account-wide roles. For more information, see _About external ID_. | |
| For enhanced security, include an external ID within the trust policies of the Support and Installer account-wide roles. For more information, see _About external ID_. |
Also, is the xref to "About external ID" missing? I don't see it as a section or additional resource in this module or its parent assembly.
There was a problem hiding this comment.
it's a module, so i did not put an xref in there. in the parent assembly, the new concept module About external ID is the one following this module, so i didn't include it as an additional resource either
jldohmann
added
the
peer-review-done
|
SME feedback provided by Aaren and Michael via slack |
|
@jldohmann: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.22 |
|
/cherrypick enterprise-4.21 |
|
@jldohmann: new pull request created: #112533 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jldohmann: new pull request created: #112534 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
Version(s): 4.21+
Issue: https://redhat.atlassian.net/browse/OSDOCS-19838
Link to docs preview:
QE review:
Additional information: