Skip to content

OSDOCS-18925:Docs updates for [OSD-GCP] allowing for edit of ingress controller to use namespaceSelector.#109873

Merged
AedinC merged 1 commit intoopenshift:mainfrom
AedinC:OSDOCS-18925
Apr 15, 2026
Merged

OSDOCS-18925:Docs updates for [OSD-GCP] allowing for edit of ingress controller to use namespaceSelector.#109873
AedinC merged 1 commit intoopenshift:mainfrom
AedinC:OSDOCS-18925

Conversation

@AedinC
Copy link
Copy Markdown
Contributor

@AedinC AedinC commented Apr 9, 2026

Version(s):
4.21+

Issue:
OSDOCS-18925

Link to docs preview:

Peer review:

  • Peer reviewer has approved this change.

SME review:

  • SME has approved this change.

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 9, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 9, 2026

@AedinC: This pull request references OSDOCS-18925 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.21+

Issue:
OSDOCS-18925

Link to docs preview:

Peer review:

  • Peer reviewer has approved this change.

SME review:

  • SME has approved this change.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 9, 2026

@AedinC: This pull request references OSDOCS-18925 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.21+

Issue:
OSDOCS-18925

Link to docs preview:

Peer review:

  • Peer reviewer has approved this change.

SME review:

  • SME has approved this change.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 9, 2026

:_mod-docs-content-type: PROCEDURE
[id="osd-create-cluster-exclude-namespace-selector-cli_{context}"]
= Setting namespace exclusions for the default ingress when you create a cluster by using the OpenShift Cluster Manager CLI
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{cluster-manager}' rather than the plain text product term 'OpenShift Cluster Manager', unless your use case is an exception.

+
Confirm that the ingress object reflects your excluded namespace settings.

[NOTE]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDocDITA.TaskStep: Content other than a single list cannot be mapped to DITA steps.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2026
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 13, 2026

@AedinC: This pull request references OSDOCS-18925 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.21+

Issue:
OSDOCS-18925

Link to docs preview:

Peer review:

  • Peer reviewer has approved this change.

SME review:

  • SME has approved this change.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@AedinC
Copy link
Copy Markdown
Contributor Author

AedinC commented Apr 13, 2026

@rcampos2029 Can you please review this? I might have added in some information that's not needed. Many thanks.

Comment thread modules/osd-create-cluster-exclude-namespace-selector-cli.adoc Outdated
Comment thread modules/osd-create-cluster-exclude-namespace-selector-cli.adoc Outdated
Comment thread modules/osd-create-cluster-exclude-namespace-selector-cli.adoc Outdated
@AedinC AedinC force-pushed the OSDOCS-18925 branch 2 times, most recently from f376cd6 to cf4ca6d Compare April 14, 2026 12:20
Comment thread modules/osd-create-cluster-exclude-namespace-selector-cli.adoc Outdated
Copy link
Copy Markdown
Contributor

@bhardesty bhardesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a couple small suggestions.

Comment thread modules/osd-create-cluster-exclude-namespace-selector-cli.adoc Outdated
Comment thread modules/osd-create-cluster-exclude-namespace-selector-cli.adoc Outdated
Comment thread modules/osd-ingress-excluded-namespaces-ocm-cli.adoc Outdated
@AedinC AedinC force-pushed the OSDOCS-18925 branch 2 times, most recently from 7c29d2a to 86989ee Compare April 14, 2026 17:43
@AedinC
Copy link
Copy Markdown
Contributor Author

AedinC commented Apr 14, 2026

Thanks @rcampos2029. Anything else that needs to be changed?

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 14, 2026

@AedinC: This pull request references OSDOCS-18925 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.21+

Issue:
OSDOCS-18925

Link to docs preview:

Peer review:

  • Peer reviewer has approved this change.

SME review:

  • SME has approved this change.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Comment thread modules/osd-ingress-excluded-namespaces-ocm-cli.adoc Outdated
Comment thread modules/osd-ingress-excluded-namespaces-ocm-cli.adoc Outdated
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2026

@AedinC: This pull request references OSDOCS-18925 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.21+

Issue:
OSDOCS-18925

Link to docs preview:

Peer review:

  • Peer reviewer has approved this change.

SME review:

  • SME has approved this change.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 15, 2026

@AedinC: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@AedinC AedinC merged commit e54d83a into openshift:main Apr 15, 2026
2 checks passed
@AedinC
Copy link
Copy Markdown
Contributor Author

AedinC commented Apr 15, 2026

/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

@openshift-cherrypick-robot
Copy link
Copy Markdown

@AedinC: new pull request created: #110160

Details

In response to this:

/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@AedinC: new pull request created: #110161

Details

In response to this:

/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.21 branch/enterprise-4.22 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants