OSDOCS-18925:Docs updates for [OSD-GCP] allowing for edit of ingress controller to use namespaceSelector.#109873
Conversation
|
@AedinC: This pull request references OSDOCS-18925 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@AedinC: This pull request references OSDOCS-18925 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
|
||
| :_mod-docs-content-type: PROCEDURE | ||
| [id="osd-create-cluster-exclude-namespace-selector-cli_{context}"] | ||
| = Setting namespace exclusions for the default ingress when you create a cluster by using the OpenShift Cluster Manager CLI |
There was a problem hiding this comment.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{cluster-manager}' rather than the plain text product term 'OpenShift Cluster Manager', unless your use case is an exception.
| + | ||
| Confirm that the ingress object reflects your excluded namespace settings. | ||
|
|
||
| [NOTE] |
There was a problem hiding this comment.
🤖 [error] AsciiDocDITA.TaskStep: Content other than a single list cannot be mapped to DITA steps.
|
@AedinC: This pull request references OSDOCS-18925 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rcampos2029 Can you please review this? I might have added in some information that's not needed. Many thanks. |
f376cd6 to
cf4ca6d
Compare
bhardesty
left a comment
There was a problem hiding this comment.
Looks great, just a couple small suggestions.
7c29d2a to
86989ee
Compare
|
Thanks @rcampos2029. Anything else that needs to be changed? |
|
@AedinC: This pull request references OSDOCS-18925 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…controller to use namespaceSelector.
|
@AedinC: This pull request references OSDOCS-18925 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@AedinC: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.21 |
|
@AedinC: new pull request created: #110160 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@AedinC: new pull request created: #110161 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.21+
Issue:
OSDOCS-18925
Link to docs preview:
Peer review:
SME review:
QE review:
Additional information: